| Message ID | 1344527635-6163-8-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote: > Before the AB8500 had its own IRQ domain, the IRQ handler would take > the fired local IRQ (hwirq) and add it to the irq_base to convert it > to an IRQ number which Linux would understand (virq). However, the > IRQ base is not always used anymore since we can make use of Linear > domains. It's better to use the AB8500 hwirq -> virq mapping helper > function to convert them instead. That's what we do here. > > CC: Samuel Ortiz <sameo@linux.intel.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> This looks better that what was in there before so Acked-by: Linus Walleij <linus.walleij@linaro.org> However: > @@ -501,8 +501,9 @@ static irqreturn_t ab8500_irq(int irq, void *dev) > do { > int bit = __ffs(value); > int line = i * 8 + bit; > + int virq = ab8500_irq_get_virq(ab8500, line); > > - handle_nested_irq(ab8500->irq_base + line); > + handle_nested_irq(virq); > value &= ~(1 << bit); Still this ab8500_irq_get_virq() business. But is this a static local function in the ab8500-core.c now? Then it's fine, it's the kernel-wide interface that is the problem. Yours, Linus Walleij
Hi Lee, On Thu, Aug 09, 2012 at 04:53:54PM +0100, Lee Jones wrote: > Before the AB8500 had its own IRQ domain, the IRQ handler would take > the fired local IRQ (hwirq) and add it to the irq_base to convert it > to an IRQ number which Linux would understand (virq). However, the > IRQ base is not always used anymore since we can make use of Linear > domains. It's better to use the AB8500 hwirq -> virq mapping helper > function to convert them instead. That's what we do here. > > CC: Samuel Ortiz <sameo@linux.intel.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/ab8500-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied now, thanks. Cheers, Samuel.
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index 0c5b70f..71a7757 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -501,8 +501,9 @@ static irqreturn_t ab8500_irq(int irq, void *dev) do { int bit = __ffs(value); int line = i * 8 + bit; + int virq = ab8500_irq_get_virq(ab8500, line); - handle_nested_irq(ab8500->irq_base + line); + handle_nested_irq(virq); value &= ~(1 << bit); } while (value);
Before the AB8500 had its own IRQ domain, the IRQ handler would take the fired local IRQ (hwirq) and add it to the irq_base to convert it to an IRQ number which Linux would understand (virq). However, the IRQ base is not always used anymore since we can make use of Linear domains. It's better to use the AB8500 hwirq -> virq mapping helper function to convert them instead. That's what we do here. CC: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/ab8500-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)