| Message ID | 1344527635-6163-9-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote: > There was a plan to place ab8500_irq_get_virq() calls in each AB8500 > child device prior to requesting an IRQ, but as we're no longer using > Device Tree to collect our IRQ numbers, it's actually better to allow > the core to do this during device registration time. So the IRQ number > we pull from its resource has already been converted to a virtual IRQ. > > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > CC: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> This is looking good, I guess you need all patches to go in at the same time so Dmitry's ACK is required. FWIW: Acked-by: Linus Walleij <linus.walleij@linaro.org> BTW: this makes me suspect that the public ab8500_irq_get_virq() interface can be *deleted* and the function made static in the AB8500 driver, right? Yours, Linus Walleij
On Tue, Aug 14, 2012 at 10:31:08AM +0200, Linus Walleij wrote: > On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > There was a plan to place ab8500_irq_get_virq() calls in each AB8500 > > child device prior to requesting an IRQ, but as we're no longer using > > Device Tree to collect our IRQ numbers, it's actually better to allow > > the core to do this during device registration time. So the IRQ number > > we pull from its resource has already been converted to a virtual IRQ. > > > > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > CC: linux-input@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > This is looking good, I guess you need all patches to go in at the > same time so Dmitry's ACK is required. Yep, just waiting for that now. > FWIW: > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > BTW: this makes me suspect that the public ab8500_irq_get_virq() > interface can be *deleted* and the function made static in the > AB8500 driver, right? Right. Already taken care of.
On Tue, Aug 21, 2012 at 10:23:29AM +0100, Lee Jones wrote: > On Tue, Aug 14, 2012 at 10:31:08AM +0200, Linus Walleij wrote: > > On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > > > There was a plan to place ab8500_irq_get_virq() calls in each AB8500 > > > child device prior to requesting an IRQ, but as we're no longer using > > > Device Tree to collect our IRQ numbers, it's actually better to allow > > > the core to do this during device registration time. So the IRQ number > > > we pull from its resource has already been converted to a virtual IRQ. > > > > > > CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > CC: linux-input@vger.kernel.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > This is looking good, I guess you need all patches to go in at the > > same time so Dmitry's ACK is required. > > Yep, just waiting for that now. Sorry for the delay. Yes, this shoudl be fine, but since it is essentially a revert of the original patch it should be pushed in as such. Thanks.
diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index f06231b..84ec691 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) ponkey->idev = input; ponkey->ab8500 = ab8500; - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); + ponkey->irq_dbf = irq_dbf; + ponkey->irq_dbr = irq_dbr; input->name = "AB8500 POn(PowerOn) Key"; input->dev.parent = &pdev->dev;
There was a plan to place ab8500_irq_get_virq() calls in each AB8500 child device prior to requesting an IRQ, but as we're no longer using Device Tree to collect our IRQ numbers, it's actually better to allow the core to do this during device registration time. So the IRQ number we pull from its resource has already been converted to a virtual IRQ. CC: Dmitry Torokhov <dmitry.torokhov@gmail.com> CC: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/misc/ab8500-ponkey.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)