diff mbox

omap: remoteproc: set bootaddr support

Message ID 1345044348-19898-1-git-send-email-jgutierrez@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Juan Gutierrez Aug. 15, 2012, 3:25 p.m. UTC 
Some remote processors (like Omap4's DSP) need to explicitly
set a boot address from which they start executing code when
taken out of reset.

Support for this has been added to remoteproc code through
a set_bootaddr function in the platform data which, if needed,
must be set according to the backend rproc.

For omap4's dsp we can use the next control funtion:

  .set_bootaddr  = omap_ctrl_write_dsp_boot_addr

Signed-off-by: Juan Gutierrez <jgutierrez@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/plat-omap/include/plat/remoteproc.h |    2 ++
 drivers/remoteproc/omap_remoteproc.c         |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)

Comments

Ohad Ben Cohen Sept. 11, 2012, 12:30 p.m. UTC | #1 
Hi Juan,

On Wed, Aug 15, 2012 at 6:25 PM, Juan Gutierrez <jgutierrez@ti.com> wrote:
> Some remote processors (like Omap4's DSP) need to explicitly
> set a boot address from which they start executing code when
> taken out of reset.
>
> Support for this has been added to remoteproc code through
> a set_bootaddr function in the platform data which, if needed,
> must be set according to the backend rproc.
>
> For omap4's dsp we can use the next control funtion:
>
>   .set_bootaddr  = omap_ctrl_write_dsp_boot_addr
>
> Signed-off-by: Juan Gutierrez <jgutierrez@ti.com>

Applied with slight changes to the commit log. Thanks!

Ohad.
Juan Gutierrez Sept. 11, 2012, 2:47 p.m. UTC | #2 
Cool. Thanks Ohad

On Tue, Sep 11, 2012 at 7:30 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:

> Hi Juan,
>
> On Wed, Aug 15, 2012 at 6:25 PM, Juan Gutierrez <jgutierrez@ti.com> wrote:
> > Some remote processors (like Omap4's DSP) need to explicitly
> > set a boot address from which they start executing code when
> > taken out of reset.
> >
> > Support for this has been added to remoteproc code through
> > a set_bootaddr function in the platform data which, if needed,
> > must be set according to the backend rproc.
> >
> > For omap4's dsp we can use the next control funtion:
> >
> >   .set_bootaddr  = omap_ctrl_write_dsp_boot_addr
> >
> > Signed-off-by: Juan Gutierrez <jgutierrez@ti.com>
>
> Applied with slight changes to the commit log. Thanks!
>
> Ohad.
>
diff mbox

Patch

diff --git a/arch/arm/plat-omap/include/plat/remoteproc.h b/arch/arm/plat-omap/include/plat/remoteproc.h
index b10eac8..3c1c644 100644
--- a/arch/arm/plat-omap/include/plat/remoteproc.h
+++ b/arch/arm/plat-omap/include/plat/remoteproc.h
@@ -30,6 +30,7 @@  struct platform_device;
  * @ops: start/stop rproc handlers
  * @device_enable: omap-specific handler for enabling a device
  * @device_shutdown: omap-specific handler for shutting down a device
+ * @set_bootaddr: omap-specific handler for setting the rproc boot address
  */
 struct omap_rproc_pdata {
 	const char *name;
@@ -40,6 +41,7 @@  struct omap_rproc_pdata {
 	const struct rproc_ops *ops;
 	int (*device_enable) (struct platform_device *pdev);
 	int (*device_shutdown) (struct platform_device *pdev);
+	void(*set_bootaddr)(u32);
 };
 
 #if defined(CONFIG_OMAP_REMOTEPROC) || defined(CONFIG_OMAP_REMOTEPROC_MODULE)
diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index a1f7ac1..a0c168c 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -116,6 +116,9 @@  static int omap_rproc_start(struct rproc *rproc)
 	struct omap_rproc_pdata *pdata = pdev->dev.platform_data;
 	int ret;
 
+	if (pdata->set_bootaddr)
+		pdata->set_bootaddr(rproc->bootaddr);
+
 	oproc->nb.notifier_call = omap_rproc_mbox_callback;
 
 	/* every omap rproc is assigned a mailbox instance for messaging */