From patchwork Thu Aug 16 11:59:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jett.Zhou" X-Patchwork-Id: 1331071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 6F3A2E010A for ; Thu, 16 Aug 2012 12:04:45 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T1ylV-0002mT-JS; Thu, 16 Aug 2012 12:01:29 +0000 Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T1ylL-0002l0-Qr for linux-arm-kernel@lists.infradead.org; Thu, 16 Aug 2012 12:01:20 +0000 Received: from MSI-MTA.marvell.com ([65.219.4.132]) (using TLSv1) by na3sys009aob111.postini.com ([74.125.148.12]) with SMTP ID DSNKUCzhCkAH81q3M5Nn21oF+avuaKnGKsX8@postini.com; Thu, 16 Aug 2012 05:01:19 PDT Received: from maili.marvell.com ([10.68.76.210]) by MSI-MTA.marvell.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 16 Aug 2012 04:57:04 -0700 Received: from localhost (unknown [10.38.164.229]) by maili.marvell.com (Postfix) with ESMTP id 310B84E50D; Thu, 16 Aug 2012 04:57:04 -0700 (PDT) From: "Jett.Zhou" To: haojian.zhuang@gmail.com, hzhuang1@marvell.com, robert.jarzmik@free.fr, a.zummo@towertech.it Subject: [PATCH 2/3] rtc: use __devinit instead on pxa-rtc Date: Thu, 16 Aug 2012 19:59:28 +0800 Message-Id: <1345118368-10409-1-git-send-email-jtzhou@marvell.com> X-Mailer: git-send-email 1.7.0.4 X-OriginalArrivalTime: 16 Aug 2012 11:57:04.0559 (UTC) FILETIME=[40CD33F0:01CD7BA6] X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.205 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: jett.zhou@gmail.com, rtc-linux@googlegroups.com, Haojian Zhuang , jtzhou@marvell.com, linux-arm-kernel@lists.infradead.org, cxie4@marvell.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Haojian Zhuang Avoid to use __init/__exit on probe()/remove(). Use __devinit/__devexit instead. Signed-off-by: Haojian Zhuang --- drivers/rtc/rtc-pxa.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c index a2c3534..3a060d2 100644 --- a/drivers/rtc/rtc-pxa.c +++ b/drivers/rtc/rtc-pxa.c @@ -308,7 +308,7 @@ static const struct rtc_class_ops pxa_rtc_ops = { .proc = pxa_rtc_proc, }; -static int __init pxa_rtc_probe(struct platform_device *pdev) +static int __devinit pxa_rtc_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct pxa_rtc *pxa_rtc; @@ -381,7 +381,7 @@ err_map: return ret; } -static int __exit pxa_rtc_remove(struct platform_device *pdev) +static int __devexit pxa_rtc_remove(struct platform_device *pdev) { struct pxa_rtc *pxa_rtc = platform_get_drvdata(pdev); @@ -422,7 +422,8 @@ static const struct dev_pm_ops pxa_rtc_pm_ops = { #endif static struct platform_driver pxa_rtc_driver = { - .remove = __exit_p(pxa_rtc_remove), + .probe = pxa_rtc_probe, + .remove = __devexit_p(pxa_rtc_remove), .driver = { .name = "pxa-rtc", #ifdef CONFIG_PM @@ -433,7 +434,7 @@ static struct platform_driver pxa_rtc_driver = { static int __init pxa_rtc_init(void) { - return platform_driver_probe(&pxa_rtc_driver, pxa_rtc_probe); + return platform_driver_register(&pxa_rtc_driver); } static void __exit pxa_rtc_exit(void)