From patchwork Tue Aug 21 09:15:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1353391 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 9A43FDFB34 for ; Tue, 21 Aug 2012 09:28:01 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3khA-0004LS-FR; Tue, 21 Aug 2012 09:24:21 +0000 Received: from na3sys009aog138.obsmtp.com ([74.125.149.19]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T3kdd-00027M-76 for linux-arm-kernel@lists.infradead.org; Tue, 21 Aug 2012 09:20:41 +0000 Received: from mail-lpp01m010-f51.google.com ([209.85.215.51]) (using TLSv1) by na3sys009aob138.postini.com ([74.125.148.12]) with SMTP ID DSNKUDNS41jcX0bseA8XI0FC9STVC2he1KFt@postini.com; Tue, 21 Aug 2012 02:20:40 PDT Received: by lahe6 with SMTP id e6so3077199lah.38 for ; Tue, 21 Aug 2012 02:20:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=kuQ/T37sELHXs3eSTuUIxY5GdmaAdVdnmsv4fA6eu5k=; b=RK8crX/YDaeN33CPwmLoP8+VBx7NMcuzT/u2PsTpjA3ZqjXpj2lbCwtvIWfdW1+rI2 AaIs18oPulDaNeblLJpHySAvqjtqbL1GmRwpMpgnG1gmYtgLiAzFzt74DeDbv3C8JzF6 npVEZ02muivp9oO1gECne44/9scE2cVu7IXXg1zS/rbgig6wsSM7/VsVwGSPRyjrU+Sn vwY5GqwP4hnLeEb1a4LC96y4pXA4Vi1iy6QP/eav2VcNWZlWjlPPK/K8ft7AeYMa2q1t vqTW1Idl6iX9k/Hrzk1sX0Jv5cdFcjoTlRd7LTur6pBgp/GKvc3XOu1t8BHyhlziVLFX ggNg== Received: by 10.152.113.68 with SMTP id iw4mr16890340lab.50.1345540833885; Tue, 21 Aug 2012 02:20:33 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id lr17sm981312lab.12.2012.08.21.02.20.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Aug 2012 02:20:32 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [RFC/PATCH 13/13] serial: omap: make sure to suspend device before remove Date: Tue, 21 Aug 2012 12:15:55 +0300 Message-Id: <1345540555-24359-14-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345540555-24359-1-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQlNCtlbiZbiud65YmZfH5JosbwdEON2veKgwiStjMngzGGgXVJ04UA+bibNtP4X0nioA1HX X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.19 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org before removing the driver, let's make sure to force device into a suspended state in order to conserve power. Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 25d2055..f849ab9 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1334,6 +1334,7 @@ static int serial_omap_remove(struct platform_device *dev) { struct uart_omap_port *up = platform_get_drvdata(dev); + pm_runtime_put_sync(up->dev); pm_runtime_disable(up->dev); uart_remove_one_port(&serial_omap_reg, &up->port); pm_qos_remove_request(&up->pm_qos_request);