From patchwork Tue Aug 21 12:16:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1354881 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 95136DFB34 for ; Tue, 21 Aug 2012 12:28:45 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3nVe-0006kr-3W; Tue, 21 Aug 2012 12:24:38 +0000 Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T3nRv-0004Sh-5J for linux-arm-kernel@lists.infradead.org; Tue, 21 Aug 2012 12:20:48 +0000 Received: from mail-lb0-f177.google.com ([209.85.217.177]) (using TLSv1) by na3sys009aob125.postini.com ([74.125.148.12]) with SMTP ID DSNKUDN9HXXtm7/USbiS0BoVdEiDK/SuLZEk@postini.com; Tue, 21 Aug 2012 05:20:46 PDT Received: by lbbgf7 with SMTP id gf7so4842286lbb.22 for ; Tue, 21 Aug 2012 05:20:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=zyhpK3f5dnsvMdtf9WhCpXhOzfn/scsPZQe453pkZos=; b=hZqrP1yp2RnX86Wu768mGDOYtQoQGPI1nUlf5pxTIdkqyFCa0opd134uIUUG3n7rle uPHVIHy4G17aruGjrKCFow0UgZwUZ/GrVJLtFe/3kTOkNAi391vQOkfbaW1DIvQNhkzo A0Eur0cScYNXPxBQhPeLcWl+xFr3AlItksixfyvFpzDTi2oh8+rOE6hQjoA10lmnZhWm LCdzNOCkJsF2ms6iypZofekKQ4cG5Qrt6ucqUUau9jvY9CZyKMsutOWZd/lVrSuVcP/k P3JBDhwM7gQ4ExZrqjgPsEqDrg7wI/9+P1ZGMC2irvhWCqFLqzZAsP4pfx/HWeJ5v/Ai foyw== Received: by 10.112.42.225 with SMTP id r1mr7548177lbl.102.1345551643526; Tue, 21 Aug 2012 05:20:43 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id gv8sm1365589lab.14.2012.08.21.05.20.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Aug 2012 05:20:42 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [PATCH v2 12/13] serial: omap: make sure to suspend device before remove Date: Tue, 21 Aug 2012 15:16:10 +0300 Message-Id: <1345551371-18862-13-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345551371-18862-1-git-send-email-balbi@ti.com> References: <1345540555-24359-1-git-send-email-balbi@ti.com> <1345551371-18862-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQmheuzLGujC/JnTtq2BIGT2MKPLFYqPFs1p5BhuitUSDaFDBghvrFSuAgGcDN5oWLlsLhN+ X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.153 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org before removing the driver, let's make sure to force device into a suspended state in order to conserve power. Acked-by: Santosh Shilimkar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 2e1a33a..b79c4fa 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1337,6 +1337,7 @@ static int serial_omap_remove(struct platform_device *dev) { struct uart_omap_port *up = platform_get_drvdata(dev); + pm_runtime_put_sync(up->dev); pm_runtime_disable(up->dev); uart_remove_one_port(&serial_omap_reg, &up->port); pm_qos_remove_request(&up->pm_qos_request);