From patchwork Wed Aug 22 13:02:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1361241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 94A3F3FD40 for ; Wed, 22 Aug 2012 13:08:02 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4Aam-0002Ob-VG; Wed, 22 Aug 2012 13:03:29 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4Aad-0002KG-2P for linux-arm-kernel@lists.infradead.org; Wed, 22 Aug 2012 13:03:24 +0000 Received: from epcpsbgm1.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M9500LTJQXF42D0@mailout1.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 22 Aug 2012 22:03:16 +0900 (KST) X-AuditID: cbfee61a-b7fc66d0000043b7-84-5034d894ab4d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 40.93.17335.498D4305; Wed, 22 Aug 2012 22:03:16 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M9500L81QX65L20@mmp1.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 22 Aug 2012 22:03:16 +0900 (KST) From: Marek Szyprowski To: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH v2] ARM: DMA-Mapping: print warning when atomic coherent allocation fails Date: Wed, 22 Aug 2012 15:02:51 +0200 Message-id: <1345640571-14349-1-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.7.10 In-reply-to: <20120822083053.42efc6162076534250112652@nvidia.com> References: <20120822083053.42efc6162076534250112652@nvidia.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEJMWRmVeSWpSXmKPExsVy+t9jAd0pN0wCDA5/VLHY9PgaqwOjx+Yl 9QGMUVw2Kak5mWWpRfp2CVwZJ2f9Yi54xF4x/9ol1gbGzWxdjJwcEgImEuePzGOGsMUkLtxb DxTn4hASWMQo0dL6kxXC2cwksaD9KwtIFZuAoUTX2y6wbhEBD4knK84xgxQxCzxlkvi7/x8j SEJYIFridcdkdhCbRUBV4vmPj2BxXqCGB3camSDWyUs8vd8HNohTwFHi6OW7QDUcQNscJBZN NprAyLuAkWEVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRrDPn0ntYFzZYHGIUYCDUYmH1yPB JECINbGsuDL3EKMEB7OSCO+j3UAh3pTEyqrUovz4otKc1OJDjNIcLErivPx9hgFCAumJJanZ qakFqUUwWSYOTqkGRtG5f5j1PD4on/RjvlfF77JNLuiZ+70te8RrCqe+ifR8NpXLXlLj/fTS FTlPpjgYH5i79cONO5zH5fe3P27ikZes5DtbvEbnvdC9eV1+AhKxiveUG3T0A9vcxNa7b3ov uUJnu1SPakekGqPW1OjXN5mFXZ+8tthw17Pk8wLLCWtWRQfothgbKrEUZyQaajEXFScCAMvN lk/1AQAA X-TM-AS-MML: No X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.24 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Andrew Lunn , Russell King - ARM Linux , Jason Cooper , Arnd Bergmann , Aaro Koskinen , Josh Coombs , Kyungmin Park , Hiroshi Doyu , Marek Szyprowski X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Print a loud warning when system runs out of memory from atomic DMA coherent pool to let users notice the potential problem. Reported-by: Aaro Koskinen Signed-off-by: Marek Szyprowski --- arch/arm/mm/dma-mapping.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index d1cc9c1..acced93 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -461,6 +461,10 @@ static void *__alloc_from_pool(size_t size, struct page **ret_page) bitmap_set(pool->bitmap, pageno, count); ptr = pool->vaddr + PAGE_SIZE * pageno; *ret_page = pool->page + pageno; + } else { + pr_err_once("ERROR: %u KiB atomic DMA coherent pool is too small!\n" + "Please increase it with coherent_pool= kernel parameter!\n", + (unsigned)pool->size / 1024); } spin_unlock_irqrestore(&pool->lock, flags);