From patchwork Thu Aug 23 10:32:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1366101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 0DFDDDF2AB for ; Thu, 23 Aug 2012 10:47:09 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4UsK-0003pz-9Z; Thu, 23 Aug 2012 10:42:57 +0000 Received: from na3sys009aog118.obsmtp.com ([74.125.149.244]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T4UnG-0000vT-S4 for linux-arm-kernel@lists.infradead.org; Thu, 23 Aug 2012 10:37:43 +0000 Received: from mail-lpp01m010-f42.google.com ([209.85.215.42]) (using TLSv1) by na3sys009aob118.postini.com ([74.125.148.12]) with SMTP ID DSNKUDYH9LB0XHm7MGIiLDrsShigTgDqGWKx@postini.com; Thu, 23 Aug 2012 03:37:42 PDT Received: by lahl5 with SMTP id l5so333513lah.29 for ; Thu, 23 Aug 2012 03:37:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=Kqu33uLViNEkLwxyAE8ocVi4LXh5K3grxqs3D3su+Wk=; b=VXvilpdP22pP6/1tjaxI0oMpw4n6bRO9fdDNDWXD4uverN4LGm87TQ0nHE9QWSW05v kknEsEclSbZGxmaE2E3kt2A60VrPnI5vSm4Byfz44NdnGXGlLuth0BKlyJDJyGHcy5nw 6zXQ07XMM44ZLiHzxr4Y8FLG69j80R1nBktb0oNGooQbuxxgGjypR5RtDfTWbZ5r0bOv 9k/JJwgk/vIWd8yR4L1VWs1fzZBKNsU0Qr0jgH/QAJ/TyVmdNcL42qWBPeCqdXMG4vog p/FpCFCRMxRFOVeQZcpFOcB8DkNVgD7EWDB4VVpoZCZB2zErfX0OhBwJMalwneZ1LHOO Rd4g== Received: by 10.112.98.70 with SMTP id eg6mr690783lbb.62.1345718259223; Thu, 23 Aug 2012 03:37:39 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id mt19sm7064200lab.17.2012.08.23.03.37.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 03:37:38 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [PATCH v3 13/23] serial: omap: don't save IRQ flags on hardirq Date: Thu, 23 Aug 2012 13:32:53 +0300 Message-Id: <1345717983-18179-14-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345717983-18179-1-git-send-email-balbi@ti.com> References: <1345717983-18179-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQlVWsLYt6xHLGmdxwf/jNGobV3oevGXPcnqE2D7TfISeLRLUbzDJebbk5dTzn/fd7cVrI62 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.244 listed in list.dnswl.org] 0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Sourav Poddar , Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When we're running our hardirq handler, there's not need to disable IRQs with spin_lock_irqsave() because IRQs are already disabled. It also makes no difference if we save or not IRQ flags. Switch over to simple spin_lock/spin_unlock and drop the "flags" variable. Tested-by: Shubhrajyoti D Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 2df725b..8a60212 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -350,11 +350,10 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id) struct tty_struct *tty = up->port.state->port.tty; unsigned int iir, lsr; unsigned int type; - unsigned long flags; irqreturn_t ret = IRQ_NONE; int max_count = 256; - spin_lock_irqsave(&up->port.lock, flags); + spin_lock(&up->port.lock); pm_runtime_get_sync(up->dev); do { @@ -393,7 +392,7 @@ static inline irqreturn_t serial_omap_irq(int irq, void *dev_id) } } while (!(iir & UART_IIR_NO_INT) && max_count--); - spin_unlock_irqrestore(&up->port.lock, flags); + spin_unlock(&up->port.lock); tty_flip_buffer_push(tty);