From patchwork Thu Aug 23 10:32:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1366111 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 687F0DF2AB for ; Thu, 23 Aug 2012 10:47:55 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4Usm-0004AV-3j; Thu, 23 Aug 2012 10:43:24 +0000 Received: from na3sys009aog130.obsmtp.com ([74.125.149.143]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T4UnJ-0000wJ-L6 for linux-arm-kernel@lists.infradead.org; Thu, 23 Aug 2012 10:37:46 +0000 Received: from mail-lb0-f179.google.com ([209.85.217.179]) (using TLSv1) by na3sys009aob130.postini.com ([74.125.148.12]) with SMTP ID DSNKUDYH93pp8vzGzNavA3FgUi5SetPXGZTz@postini.com; Thu, 23 Aug 2012 03:37:45 PDT Received: by lbao2 with SMTP id o2so274193lba.38 for ; Thu, 23 Aug 2012 03:37:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=N/oJUvvM493l3bjQtPL2rl2fyNWVAD2VU6fbbzPMT0Y=; b=jdG+qv4RGn8oZz4CwTKrclWoxMniqb+VB3E20NczVjM9PZs5jKqTWQhx5/jkoOvS7C 0FkpoMzH+EduiMu9Qm2eLJwomLDPXRf0AwndGvvT4z/1baImAvc7jpeYoNlLRdLw950C aZ1u4QdZXsnWTGQLZihTFgg4vkgdJHi8D9UZRbfj6OUap71GRA+Puq/5BgG/LAwhLc1y U9EzFx2NLVDGshXlxYwaeq6aCcUNwM9UPUo8Ot9reXrYWh98Wz9/UleelKsDSKT4zcEu KSF/9HzRiPfQ6tUJhEoTYbu8qi9m2kOJI37gCRTIe1x9ywMg+AIIuSYKf8WxMFMjzQIT joIA== Received: by 10.112.47.133 with SMTP id d5mr674246lbn.47.1345718262044; Thu, 23 Aug 2012 03:37:42 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id sm7sm7096157lab.5.2012.08.23.03.37.40 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 03:37:41 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [PATCH v3 14/23] serial: omap: fix sequence of pm_runtime_* calls. Date: Thu, 23 Aug 2012 13:32:54 +0300 Message-Id: <1345717983-18179-15-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345717983-18179-1-git-send-email-balbi@ti.com> References: <1345717983-18179-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQmsjAO443h99+7mtJ9apLib+4g5AdjmQYtlWnWpqomyE4q53h4VisazdVTLcuq1K5aaMVNz X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.143 listed in list.dnswl.org] 0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Nishanth Menon , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Sourav Poddar , Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , Ruchika Kharwar X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Ruchika Kharwar pm_runtime_enable() needs to be invoked before pm_runtime_use_autosuspend(), and pm_runtime_set_autosuspend_delay() functions. Tested-by: Shubhrajyoti D Signed-off-by: Nishanth Menon Signed-off-by: Ruchika Kharwar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 8a60212..8254561 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1300,12 +1300,12 @@ static int serial_omap_probe(struct platform_device *pdev) INIT_WORK(&up->qos_work, serial_omap_uart_qos_work); platform_set_drvdata(pdev, up); + pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, omap_up_info->autosuspend_timeout); pm_runtime_irq_safe(&pdev->dev); - pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); omap_serial_fill_features_erratas(up);