From patchwork Thu Aug 23 10:32:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1366191 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id D19CEDF2AB for ; Thu, 23 Aug 2012 10:49:11 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T4UuG-0005LL-U9; Thu, 23 Aug 2012 10:44:58 +0000 Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T4UnR-0000zd-Kf for linux-arm-kernel@lists.infradead.org; Thu, 23 Aug 2012 10:37:54 +0000 Received: from mail-lpp01m010-f48.google.com ([209.85.215.48]) (using TLSv1) by na3sys009aob117.postini.com ([74.125.148.12]) with SMTP ID DSNKUDYH/1YUcJ3QTqC4bFAnktwJvSdkMMsg@postini.com; Thu, 23 Aug 2012 03:37:53 PDT Received: by lagr15 with SMTP id r15so368182lag.35 for ; Thu, 23 Aug 2012 03:37:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=cAdoMVZ5hlva0CUu9ZD595CMR2TXbdidZbe/3denl4Q=; b=AQ4fy9NSWWcMPrRpGSy/edRRJglL+XJz50hEvX+C38s/fpFph2h9i088FQW8JUYGgG tBvXZ8cf94FMGXGri1dUJfij2AEuvuSrHgbceXm/9JIOFZiya4h8pOynv8dRhYN0YgG+ /kRUKUUwoNi+BgVm53tH/pJLYjb2pgVqGOVQSrduBdnwHt2cGpfVjS6++cVouiP2GvsL aQkuJwsf3VKJIaTr3e2hEyQJn0+CyYXeDr830ZOSDK7a+KSY5fR7SLLDpBg5uuCK1Shy XKJG3DAqeCFNTwFABVHv2FiPqD/ZyRxKRmy1KIyZFTNaviiI93SdUW9Yqf+GTO3fbFF5 +CDQ== Received: by 10.152.122.9 with SMTP id lo9mr1189832lab.41.1345718269919; Thu, 23 Aug 2012 03:37:49 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id n7sm1781469lbk.10.2012.08.23.03.37.48 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Aug 2012 03:37:49 -0700 (PDT) From: Felipe Balbi To: alan@linux.intel.com Subject: [PATCH v3 17/23] serial: omap: unlock the port lock Date: Thu, 23 Aug 2012 13:32:57 +0300 Message-Id: <1345717983-18179-18-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1345717983-18179-1-git-send-email-balbi@ti.com> References: <1345717983-18179-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQmbexPxz5oSuKN1vgsPWSlPgzzZRxchho439vWqnGUm+jP6snUTouhUciY8zOKqvw9pmqz8 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.242 listed in list.dnswl.org] 0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Pavan Savoy , Santosh Shilimkar , linux-serial@vger.kernel.org, Sourav Poddar , Linux OMAP Mailing List , Vijay Badawadagi , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , Ruchika Kharwar X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Ruchika Kharwar This patch unlocks the port lock before calling a serial_core API and re-acquires the port lock after calling it. This patch fixes a system freeze issue seen when the serial_core API uart_write_wakeup() eventually attempts to acquire the port lock already acquired by omap serial interrupt handler. Tested-by: Shubhrajyoti D Signed-off-by: Ruchika Kharwar Signed-off-by: Pavan Savoy Signed-off-by: Vijay Badawadagi Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index ba22247..e871635 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -223,8 +223,11 @@ static void transmit_chars(struct uart_omap_port *up, unsigned int lsr) break; } while (--count > 0); - if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) + if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) { + spin_unlock(&up->port.lock); uart_write_wakeup(&up->port); + spin_lock(&up->port.lock); + } if (uart_circ_empty(xmit)) serial_omap_stop_tx(&up->port);