diff mbox

[5/6] arm: mvebu: add Aurora L2 Cache Controller to the DT

Message ID 1345799361-23735-6-git-send-email-gregory.clement@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gregory CLEMENT Aug. 24, 2012, 9:09 a.m. UTC 
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Yehuda Yitschak <yehuday@marvell.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Olof Johansson <olof@lixom.net>
---
 arch/arm/boot/dts/armada-370.dtsi |    6 ++++++
 arch/arm/boot/dts/armada-xp.dtsi  |    7 +++++++
 2 files changed, 13 insertions(+)

Comments

Ian Molton Aug. 24, 2012, 2:56 p.m. UTC | #1 
On 24/08/12 11:09, Gregory CLEMENT wrote:
> + compatible = "marvell,aurora-cache-with-outer";

This reads wrong.

perhaps aurora-with-outer-cache?

or better, perhaps something like:

compatible = "marvell,armada370", "marvell,armada-370-xp";
    L2: l2-cache {
        compatible = "marvell,aurora-cache-with-outer";
        reg = <0xd0008000 0x1000>;
        cache-id-part = <0x100>;
        wt-override;
        with-outer="yes";
    };
Gregory CLEMENT Aug. 24, 2012, 3:15 p.m. UTC | #2 
On 08/24/2012 04:56 PM, Ian Molton wrote:> On 24/08/12 11:09, Gregory CLEMENT wrote:
>> + compatible = "marvell,aurora-cache-with-outer";
>
> This reads wrong.
>
> perhaps aurora-with-outer-cache?

We can use
compatible = "marvell,aurora-outer-cache"
and
compatible = "marvell,aurora-system-cache"

which is a better description of the L2 cache controller indeed.

>
> or better, perhaps something like:
>
> compatible = "marvell,armada370", "marvell,armada-370-xp";
>     L2: l2-cache {										
>         compatible = "marvell,aurora-cache-with-outer";	
>         reg = <0xd0008000 0x1000>;						
>         cache-id-part = <0x100>;							
>         wt-override;										
>         with-outer="yes";									
>     };


I guess you meant:

compatible = "marvell,armada370", "marvell,armada-370-xp";
    L2: l2-cache {										
        compatible = "marvell,aurora-cache";
        reg = <0xd0008000 0x1000>;
        cache-id-part = <0x100>;
        wt-override;
        with-outer="yes";
    };

But in this case the association between compatible strings and data
won't work (see PATCH 3/6).
Ian Molton Aug. 27, 2012, 9:25 a.m. UTC | #3 
On 24/08/12 17:15, Gregory CLEMENT wrote:
> On 08/24/2012 04:56 PM, Ian Molton wrote:> On 24/08/12 11:09, Gregory CLEMENT wrote:
>>> + compatible = "marvell,aurora-cache-with-outer";
>> This reads wrong.
>>
>> perhaps aurora-with-outer-cache?
> We can use
> compatible = "marvell,aurora-outer-cache"
> and
> compatible = "marvell,aurora-system-cache"
>
> which is a better description of the L2 cache controller indeed.

Yes, much clearer.

> I guess you meant:
>
> compatible = "marvell,armada370", "marvell,armada-370-xp";
>     L2: l2-cache {										
>         compatible = "marvell,aurora-cache";
>         reg = <0xd0008000 0x1000>;
>         cache-id-part = <0x100>;
>         wt-override;
>         with-outer="yes";
>     };

Yes :)

-Ian
Gregory CLEMENT Aug. 27, 2012, 5:32 p.m. UTC | #4 
On 08/27/2012 11:25 AM, Ian Molton wrote:
> On 24/08/12 17:15, Gregory CLEMENT wrote:
>> On 08/24/2012 04:56 PM, Ian Molton wrote:> On 24/08/12 11:09, Gregory CLEMENT wrote:
>>>> + compatible = "marvell,aurora-cache-with-outer";
>>> This reads wrong.
>>>
>>> perhaps aurora-with-outer-cache?
>> We can use
>> compatible = "marvell,aurora-outer-cache"
>> and
>> compatible = "marvell,aurora-system-cache"
>>
>> which is a better description of the L2 cache controller indeed.
> 
> Yes, much clearer.

OK I will change this in next version.

> 
>> I guess you meant:
>>
>> compatible = "marvell,armada370", "marvell,armada-370-xp";
>>     L2: l2-cache {										
>>         compatible = "marvell,aurora-cache";
>>         reg = <0xd0008000 0x1000>;
>>         cache-id-part = <0x100>;
>>         wt-override;
>>         with-outer="yes";
>>     };
> 
> Yes :)
> 
> -Ian
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
index 3228ccc..43fa832 100644
--- a/arch/arm/boot/dts/armada-370.dtsi
+++ b/arch/arm/boot/dts/armada-370.dtsi
@@ -20,6 +20,12 @@ 
 / {
 	model = "Marvell Armada 370 family SoC";
 	compatible = "marvell,armada370", "marvell,armada-370-xp";
+	L2: l2-cache {
+		compatible = "marvell,aurora-cache-with-outer";
+		reg = <0xd0008000 0x1000>;
+		cache-id-part = <0x100>;
+		wt-override;
+	};
 
 	mpic: interrupt-controller@d0020000 {
 	      reg = <0xd0020a00 0x1d0>,
diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
index 71d6b5d..f045a63 100644
--- a/arch/arm/boot/dts/armada-xp.dtsi
+++ b/arch/arm/boot/dts/armada-xp.dtsi
@@ -22,6 +22,13 @@ 
 	model = "Marvell Armada XP family SoC";
 	compatible = "marvell,armadaxp", "marvell,armada-370-xp";
 
+	L2: l2-cache {
+		compatible = "marvell,aurora-cache-no-outer";
+		reg = <0xd0008000 0x1000>;
+		cache-id-part = <0x100>;
+		wt-override;
+	};
+
 	mpic: interrupt-controller@d0020000 {
 	      reg = <0xd0020a00 0x1d0>,
 		    <0xd0021870 0x58>;