diff mbox

ARM: ux500: set proper GIC flags

Message ID 1345813264-4896-1-git-send-email-linus.walleij@stericsson.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Aug. 24, 2012, 1:01 p.m. UTC
From: Linus Walleij <linus.walleij@linaro.org>

The Ux500 will be able to wake up on any IRQ, so flag it with
IRQCHIP_SKIP_SET_WAKE, and we want to mask off the IRQs when
going to suspend to avoid transient effects so also flag
this with IRQCHIP_MASK_ON_SUSPEND.

Cc: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/mach-ux500/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Santosh Shilimkar Aug. 24, 2012, 1:08 p.m. UTC | #1
On Fri, Aug 24, 2012 at 6:31 PM, Linus Walleij
<linus.walleij@stericsson.com> wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The Ux500 will be able to wake up on any IRQ, so flag it with
> IRQCHIP_SKIP_SET_WAKE, and we want to mask off the IRQs when
> going to suspend to avoid transient effects so also flag
> this with IRQCHIP_MASK_ON_SUSPEND.
>
> Cc: Etienne Carriere <etienne.carriere@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  arch/arm/mach-ux500/cpu.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index e2360e7..2957432 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -51,6 +51,8 @@ void __init ux500_init_irq(void)
>         void __iomem *dist_base;
>         void __iomem *cpu_base;
>
> +       gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
> +
With this patch, you should no longer need the dummy set_irq_wake()
patch which I was form
you for ux500.

Regards
Santosh
Linus Walleij Aug. 24, 2012, 8:28 p.m. UTC | #2
On Fri, Aug 24, 2012 at 3:08 PM, Shilimkar, Santosh
<santosh.shilimkar@ti.com> wrote:
>> +       gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
>> +
> With this patch, you should no longer need the dummy set_irq_wake()
> patch which I was form
> you for ux500.

Yep, it's somehow gone already (though it was preserved on the
internal kernel...)

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
index e2360e7..2957432 100644
--- a/arch/arm/mach-ux500/cpu.c
+++ b/arch/arm/mach-ux500/cpu.c
@@ -51,6 +51,8 @@  void __init ux500_init_irq(void)
 	void __iomem *dist_base;
 	void __iomem *cpu_base;
 
+	gic_arch_extn.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_MASK_ON_SUSPEND;
+
 	if (cpu_is_u8500_family()) {
 		dist_base = __io_address(U8500_GIC_DIST_BASE);
 		cpu_base = __io_address(U8500_GIC_CPU_BASE);