| Message ID | 1345816913-4113-6-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ola poke. On Fri, Aug 24, 2012 at 03:01:41PM +0100, Lee Jones wrote: > Includes removal of duplicate debug print affirming entry into > the probe function, an unnecessary line break of a coding line > <80 chars and a white space change (unintentional tab). > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > sound/soc/ux500/mop500.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c > index 6840df7..356611d 100644 > --- a/sound/soc/ux500/mop500.c > +++ b/sound/soc/ux500/mop500.c > @@ -88,8 +88,6 @@ static int __devinit mop500_probe(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > int ret; > > - pr_debug("%s: Enter.\n", __func__); > - > dev_dbg(&pdev->dev, "%s: Enter.\n", __func__); > > mop500_card.dev = &pdev->dev; > @@ -117,8 +115,7 @@ static int __devinit mop500_probe(struct platform_device *pdev) > ret = snd_soc_register_card(&mop500_card); > if (ret) > dev_err(&pdev->dev, > - "Error: snd_soc_register_card failed (%d)!\n", > - ret); > + "Error: snd_soc_register_card failed (%d)!\n", ret); > > return ret; > } > @@ -131,7 +128,7 @@ static int __devexit mop500_remove(struct platform_device *pdev) > > snd_soc_unregister_card(mop500_card); > mop500_ab8500_remove(mop500_card); > - > + > return 0; > } > > -- > 1.7.9.5 >
On Mon, Sep 10, 2012 at 05:44:49PM +0100, Lee Jones wrote:
> Ola poke.
Please don't send contentless top-posted pings - if you think things
have been forgotten you should generally resend them, there's a good
chance that if things have been lost people don't have the original any
more. Replying means the patch is quoted so is painful to apply if
anyone wants to test (or otherwise apply the patch) and top posting is
generally frowned upon.
On 09/10/2012 06:44 PM, Lee Jones wrote: > Ola poke. > > On Fri, Aug 24, 2012 at 03:01:41PM +0100, Lee Jones wrote: >> Includes removal of duplicate debug print affirming entry into >> the probe function, an unnecessary line break of a coding line >> <80 chars and a white space change (unintentional tab). >> >> Signed-off-by: Lee Jones <lee.jones@linaro.org> >> --- >> sound/soc/ux500/mop500.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c >> index 6840df7..356611d 100644 >> --- a/sound/soc/ux500/mop500.c >> +++ b/sound/soc/ux500/mop500.c >> @@ -88,8 +88,6 @@ static int __devinit mop500_probe(struct platform_device *pdev) >> struct device_node *np = pdev->dev.of_node; >> int ret; >> >> - pr_debug("%s: Enter.\n", __func__); >> - >> dev_dbg(&pdev->dev, "%s: Enter.\n", __func__); >> >> mop500_card.dev = &pdev->dev; >> @@ -117,8 +115,7 @@ static int __devinit mop500_probe(struct platform_device *pdev) >> ret = snd_soc_register_card(&mop500_card); >> if (ret) >> dev_err(&pdev->dev, >> - "Error: snd_soc_register_card failed (%d)!\n", >> - ret); >> + "Error: snd_soc_register_card failed (%d)!\n", ret); >> >> return ret; >> } >> @@ -131,7 +128,7 @@ static int __devexit mop500_remove(struct platform_device *pdev) >> >> snd_soc_unregister_card(mop500_card); >> mop500_ab8500_remove(mop500_card); >> - >> + >> return 0; >> } >> >> -- >> 1.7.9.5 >> > Nothing to say about this one. Looks OK.
diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c index 6840df7..356611d 100644 --- a/sound/soc/ux500/mop500.c +++ b/sound/soc/ux500/mop500.c @@ -88,8 +88,6 @@ static int __devinit mop500_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; int ret; - pr_debug("%s: Enter.\n", __func__); - dev_dbg(&pdev->dev, "%s: Enter.\n", __func__); mop500_card.dev = &pdev->dev; @@ -117,8 +115,7 @@ static int __devinit mop500_probe(struct platform_device *pdev) ret = snd_soc_register_card(&mop500_card); if (ret) dev_err(&pdev->dev, - "Error: snd_soc_register_card failed (%d)!\n", - ret); + "Error: snd_soc_register_card failed (%d)!\n", ret); return ret; } @@ -131,7 +128,7 @@ static int __devexit mop500_remove(struct platform_device *pdev) snd_soc_unregister_card(mop500_card); mop500_ab8500_remove(mop500_card); - + return 0; }
Includes removal of duplicate debug print affirming entry into the probe function, an unnecessary line break of a coding line <80 chars and a white space change (unintentional tab). Signed-off-by: Lee Jones <lee.jones@linaro.org> --- sound/soc/ux500/mop500.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)