From patchwork Sun Aug 26 21:39:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaccon Bastiaansen X-Patchwork-Id: 1375861 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 94179DFABE for ; Sun, 26 Aug 2012 21:42:26 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T5kYa-0008Jk-M2; Sun, 26 Aug 2012 21:39:45 +0000 Received: from mail-wg0-f45.google.com ([74.125.82.45]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T5kYX-0008J4-KE for linux-arm-kernel@lists.infradead.org; Sun, 26 Aug 2012 21:39:42 +0000 Received: by wgbdq12 with SMTP id dq12so2450518wgb.26 for ; Sun, 26 Aug 2012 14:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=hl29CsWjs2PzV47znbqbHdl8xFqnCcpyunAMQdFXpY4=; b=hE3X7Hd8T+wF7s0fejGlKU9dKJ9LZd+udzW4SEnMekjJKI/ZctxeJSUeAY3m+kJBem Yy5mAfhi5mHq+ZpBz+l/fcNSlCXuMzacKnvUB7Sqh7tXhFtLDEouaR30CfR4K0iFTGCB 2w3+9jzqv2cPZuMCmafS1kJ6UfqYL70kG9EjX4VTdliD45H1tTmuaIpONNbKrt56sT1P pUupBmQ3tj3wpIWQSTczG9DxqcSi3K/daFSGlSy68klGDYvPP8i8d4KZp2Q0X0q+GgVK kqC0vbqRJvAu5SL+oq/F3vU7xpXw0loEUnB9mP0tLXcHhqULGE4FkCZX8VUgknLHf0Dx wydQ== Received: by 10.180.97.106 with SMTP id dz10mr20375134wib.21.1346017179677; Sun, 26 Aug 2012 14:39:39 -0700 (PDT) Received: from localhost.localdomain (s529d540e.adsl.wanadoo.nl. [82.157.84.14]) by mx.google.com with ESMTPS id r9sm17271684wia.2.2012.08.26.14.39.37 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 26 Aug 2012 14:39:38 -0700 (PDT) From: Jaccon Bastiaansen To: davem@davemloft.net, joe@perches.com Subject: [PATCH] cs89x0 : packet reception not working Date: Sun, 26 Aug 2012 23:39:06 +0200 Message-Id: <1346017146-28248-1-git-send-email-jaccon.bastiaansen@gmail.com> X-Mailer: git-send-email 1.7.1 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.45 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jaccon.bastiaansen[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: netdev@vger.kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, Jaccon Bastiaansen , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The RxCFG register of the CS89x0 could be configured incorrectly (because of misplaced parentheses), resulting in the disabling of packet reception. Signed-off-by: Jaccon Bastiaansen --- drivers/net/ethernet/cirrus/cs89x0.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c index 845b202..ea521fa 100644 --- a/drivers/net/ethernet/cirrus/cs89x0.c +++ b/drivers/net/ethernet/cirrus/cs89x0.c @@ -1261,10 +1261,10 @@ static void set_multicast_list(struct net_device *dev) * so we have to enable interrupts on them also */ writereg(dev, PP_RxCFG, - (lp->curr_rx_cfg | - (lp->rx_mode == RX_ALL_ACCEPT) - ? (RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL) - : 0)); + lp->curr_rx_cfg | + (lp->rx_mode == RX_ALL_ACCEPT + ? (RX_CRC_ERROR_ENBL | RX_RUNT_ENBL | RX_EXTRA_DATA_ENBL) + : 0)); spin_unlock_irqrestore(&lp->lock, flags); }