diff mbox

[1/3] ARM: mx28evk: Add SPI flash support

Message ID 1346084609-31407-1-git-send-email-fabio.estevam@freescale.com
State New, archived
Headers show

Commit Message

Fabio Estevam Aug. 27, 2012, 4:23 p.m. UTC
mx28evk has a free slot (J89) which can be used to populate an SPI NOR Flash.

Add support for it.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx28-evk.dts |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Marek Vasut Aug. 27, 2012, 4:58 p.m. UTC | #1
Dear Fabio Estevam,

> mx28evk has a free slot (J89) which can be used to populate an SPI NOR
> Flash.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx28-evk.dts |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx28-evk.dts
> b/arch/arm/boot/dts/imx28-evk.dts index ab78ee5..8a9a2f4 100644
> --- a/arch/arm/boot/dts/imx28-evk.dts
> +++ b/arch/arm/boot/dts/imx28-evk.dts
> @@ -46,6 +46,23 @@
>  				wp-gpios = <&gpio0 28 0>;
>  			};
> 
> +			ssp2: ssp@80014000 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "fsl,imx28-spi";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&spi2_pins_a>;
> +				status = "okay";
> +
> +				flash: m25p80@0 {

Shouldn't this also be sst25vf016b@0 ?

> +					#address-cells = <1>;
> +					#size-cells = <1>;
> +					compatible = "sst,sst25vf016b";
> +					spi-max-frequency = <40000000>;
> +					reg = <0>;
> +				};
> +			};
> +
>  			pinctrl@80018000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&hog_pins_a>;

Best regards,
Marek Vasut
Fabio Estevam Aug. 27, 2012, 7:46 p.m. UTC | #2
On Mon, Aug 27, 2012 at 1:58 PM, Marek Vasut <marex@denx.de> wrote:

>> +                     ssp2: ssp@80014000 {
>> +                             #address-cells = <1>;
>> +                             #size-cells = <0>;
>> +                             compatible = "fsl,imx28-spi";
>> +                             pinctrl-names = "default";
>> +                             pinctrl-0 = <&spi2_pins_a>;
>> +                             status = "okay";
>> +
>> +                             flash: m25p80@0 {
>
> Shouldn't this also be sst25vf016b@0 ?

The alias is still m25p80 in this case.

Regards,

Fabio Estevam
Shawn Guo Aug. 28, 2012, 12:40 a.m. UTC | #3
On Mon, Aug 27, 2012 at 01:23:27PM -0300, Fabio Estevam wrote:
> mx28evk has a free slot (J89) which can be used to populate an SPI NOR Flash.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied all three patches, thanks.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
index ab78ee5..8a9a2f4 100644
--- a/arch/arm/boot/dts/imx28-evk.dts
+++ b/arch/arm/boot/dts/imx28-evk.dts
@@ -46,6 +46,23 @@ 
 				wp-gpios = <&gpio0 28 0>;
 			};
 
+			ssp2: ssp@80014000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx28-spi";
+				pinctrl-names = "default";
+				pinctrl-0 = <&spi2_pins_a>;
+				status = "okay";
+
+				flash: m25p80@0 {
+					#address-cells = <1>;
+					#size-cells = <1>;
+					compatible = "sst,sst25vf016b";
+					spi-max-frequency = <40000000>;
+					reg = <0>;
+				};
+			};
+
 			pinctrl@80018000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&hog_pins_a>;