| Message ID | 1346405361-29711-2-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* AnilKumar Ch <anilkumar@ti.com> [120831 02:30]: > Adds basic pinctrl device tree data for AM33XX family of devices. > This patch is based on the pinctrl-single driver. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index be43511..bf5f713 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -40,6 +40,15 @@ > }; > }; > > + am3358_pinmux: pinmux@44e10800 { > + compatible = "pinctrl-single"; > + reg = <0x44e10800 0x0238>; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-single,register-width = <32>; > + pinctrl-single,function-mask = <0x7f>; > + }; > + Is this controller the same for all am33xx? If so, please use am33xx_pinmux naming. Note that some padconf registers may not be listed for all the variants, but the registers may still be there for all the variants. So a generic entry is a better choice here as otherwise you'l need to include am33xx.dtsi into am3358.dtsi. Regards, Tony
On Thu, Sep 06, 2012 at 05:02:05, Tony Lindgren wrote: > * AnilKumar Ch <anilkumar@ti.com> [120831 02:30]: > > Adds basic pinctrl device tree data for AM33XX family of devices. > > This patch is based on the pinctrl-single driver. > > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > --- > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index be43511..bf5f713 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -40,6 +40,15 @@ > > }; > > }; > > > > + am3358_pinmux: pinmux@44e10800 { > > + compatible = "pinctrl-single"; > > + reg = <0x44e10800 0x0238>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + pinctrl-single,register-width = <32>; > > + pinctrl-single,function-mask = <0x7f>; > > + }; > > + > > Is this controller the same for all am33xx? If so, please use > am33xx_pinmux naming. Note that some padconf registers may not > be listed for all the variants, but the registers may still be > there for all the variants. So a generic entry is a better > choice here as otherwise you'l need to include am33xx.dtsi into > am3358.dtsi. > Controller is same for all am33xx devices, I will spin a patch by renaming to am33xx_**** Thanks AnilKumar
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index be43511..bf5f713 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -40,6 +40,15 @@ }; }; + am3358_pinmux: pinmux@44e10800 { + compatible = "pinctrl-single"; + reg = <0x44e10800 0x0238>; + #address-cells = <1>; + #size-cells = <0>; + pinctrl-single,register-width = <32>; + pinctrl-single,function-mask = <0x7f>; + }; + /* * XXX: Use a flat representation of the AM33XX interconnect. * The real AM33XX interconnect network is quite complex.Since
Adds basic pinctrl device tree data for AM33XX family of devices. This patch is based on the pinctrl-single driver. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)