| Message ID | 1346666749-6094-1-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Which tree your patches are based on? Neither does it apply on v3.6-rc nor my mxs/dt-for-3.7 branch. Nit: The "*" in subject is not really needed. "... in SSP nodes" looks just fine. Regards, Shawn On Mon, Sep 03, 2012 at 12:05:47PM +0200, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm/boot/dts/imx28.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi > index 26a166c..8497a0e 100644 > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -86,6 +86,8 @@ > }; > > ssp0: ssp@80010000 { > + #address-cells = <1>; > + #size-cells = <0>; > reg = <0x80010000 2000>; > interrupts = <96 82>; > fsl,ssp-dma-channel = <0>; > @@ -93,6 +95,8 @@ > }; > > ssp1: ssp@80012000 { > + #address-cells = <1>; > + #size-cells = <0>; > reg = <0x80012000 2000>; > interrupts = <97 83>; > fsl,ssp-dma-channel = <1>; > @@ -100,6 +104,8 @@ > }; > > ssp2: ssp@80014000 { > + #address-cells = <1>; > + #size-cells = <0>; > reg = <0x80014000 2000>; > interrupts = <98 84>; > fsl,ssp-dma-channel = <2>; > @@ -107,6 +113,8 @@ > }; > > ssp3: ssp@80016000 { > + #address-cells = <1>; > + #size-cells = <0>; > reg = <0x80016000 2000>; > interrupts = <99 85>; > fsl,ssp-dma-channel = <3>; > -- > 1.7.9.5 >
Hi Shawn, Le 03/09/2012 16:49, Shawn Guo a écrit : > Which tree your patches are based on? Neither does it apply on v3.6-rc > nor my mxs/dt-for-3.7 branch. They are based on 3.6-rc1 + Marek Vasut's patches for SPI ([PATCH v3] MXS SPI Driver sent the 08/03). But it looks like the last patch that was never merged, and it was actually adding the muxing options to the imx28 dtsi file. I'll remove that patch from my tree and send a new version of this patch. > Nit: The "*" in subject is not really needed. "... in SSP nodes" looks > just fine. Ok, I will remove it in the next version. Thanks, Maxime
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 26a166c..8497a0e 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -86,6 +86,8 @@ }; ssp0: ssp@80010000 { + #address-cells = <1>; + #size-cells = <0>; reg = <0x80010000 2000>; interrupts = <96 82>; fsl,ssp-dma-channel = <0>; @@ -93,6 +95,8 @@ }; ssp1: ssp@80012000 { + #address-cells = <1>; + #size-cells = <0>; reg = <0x80012000 2000>; interrupts = <97 83>; fsl,ssp-dma-channel = <1>; @@ -100,6 +104,8 @@ }; ssp2: ssp@80014000 { + #address-cells = <1>; + #size-cells = <0>; reg = <0x80014000 2000>; interrupts = <98 84>; fsl,ssp-dma-channel = <2>; @@ -107,6 +113,8 @@ }; ssp3: ssp@80016000 { + #address-cells = <1>; + #size-cells = <0>; reg = <0x80016000 2000>; interrupts = <99 85>; fsl,ssp-dma-channel = <3>;
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- arch/arm/boot/dts/imx28.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)