| Message ID | 1346748609-11115-5-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Tomasz Figa wrote: > > Some boards have larger memory banks than 256MiB. This patch increses > maximum bank size for Exynos-based boards to 512MiB. > Well...the meaning of SECTION_SIZE_BITS is a little bit different you know. Please refer to following thread. http://lists.infradead.org/pipermail/linux-arm-kernel/2010-July/020184.html Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/mach-exynos/include/mach/memory.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/include/mach/memory.h b/arch/arm/mach- > exynos/include/mach/memory.h > index 374ef2c..d4db508 100644 > --- a/arch/arm/mach-exynos/include/mach/memory.h > +++ b/arch/arm/mach-exynos/include/mach/memory.h > @@ -15,8 +15,8 @@ > > #define PLAT_PHYS_OFFSET UL(0x40000000) > > -/* Maximum of 256MiB in one bank */ > +/* Maximum of 512MiB in one bank */ > #define MAX_PHYSMEM_BITS 32 > -#define SECTION_SIZE_BITS 28 > +#define SECTION_SIZE_BITS 29 > > #endif /* __ASM_ARCH_MEMORY_H */ > -- > 1.7.12
Hi Kgene, On Saturday 08 of September 2012 11:41:31 Kukjin Kim wrote: > Tomasz Figa wrote: > > Some boards have larger memory banks than 256MiB. This patch increses > > maximum bank size for Exynos-based boards to 512MiB. > > Well...the meaning of SECTION_SIZE_BITS is a little bit different you > know. > > Please refer to following thread. > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-July/020184.ht > ml Well, I agree, but the effect of this patch is that it is possible to have first bank (or rather section) up to 512MiB, in case of CONFIG_SPARSEMEM. Still, we could go the other way and just define more smaller sections instead and simply drop this patch. (Assuming that the correspondence of sections and memory banks is irrelevant.) -- Best regards, Tomasz Figa
diff --git a/arch/arm/mach-exynos/include/mach/memory.h b/arch/arm/mach-exynos/include/mach/memory.h index 374ef2c..d4db508 100644 --- a/arch/arm/mach-exynos/include/mach/memory.h +++ b/arch/arm/mach-exynos/include/mach/memory.h @@ -15,8 +15,8 @@ #define PLAT_PHYS_OFFSET UL(0x40000000) -/* Maximum of 256MiB in one bank */ +/* Maximum of 512MiB in one bank */ #define MAX_PHYSMEM_BITS 32 -#define SECTION_SIZE_BITS 28 +#define SECTION_SIZE_BITS 29 #endif /* __ASM_ARCH_MEMORY_H */