| Message ID | 1346845260-10978-4-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/05/2012 01:41 PM, AnilKumar Ch wrote: > Add Bosch D_CAN controller device tree data to AM33XX dtsi > file by adding d_can device nodes with all the necessary > parameters. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index bf5f713..ab744d6 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -177,5 +177,23 @@ > compatible = "ti,omap3-wdt"; > ti,hwmods = "wd_timer2"; > }; > + > + dcan0: d_can@481cc000 { > + compatible = "bosch,d_can"; On imx/mxs we also add a compatible for the current hardware, this may look like this: compatible = "ti,am33xx-can", "bosch,d_can"; But I don't know if this is a generic policy or just an imx/mxs thing :) Marc > + ti,hwmods = "d_can0"; > + reg = <0x481cc000 0x2000>; > + interrupts = <52>; > + interrupt-parent = <&intc>; > + status = "disabled"; > + }; > + > + dcan1: d_can@481d0000 { > + compatible = "bosch,d_can"; > + ti,hwmods = "d_can1"; > + reg = <0x481d0000 0x2000>; > + interrupts = <55>; > + interrupt-parent = <&intc>; > + status = "disabled"; > + }; > }; > }; >
On Wed, Sep 05, 2012 at 19:16:58, Marc Kleine-Budde wrote: > On 09/05/2012 01:41 PM, AnilKumar Ch wrote: > > Add Bosch D_CAN controller device tree data to AM33XX dtsi > > file by adding d_can device nodes with all the necessary > > parameters. > > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > --- > > arch/arm/boot/dts/am33xx.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index bf5f713..ab744d6 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -177,5 +177,23 @@ > > compatible = "ti,omap3-wdt"; > > ti,hwmods = "wd_timer2"; > > }; > > + > > + dcan0: d_can@481cc000 { > > + compatible = "bosch,d_can"; > > On imx/mxs we also add a compatible for the current hardware, this may > look like this: > > compatible = "ti,am33xx-can", "bosch,d_can"; > > But I don't know if this is a generic policy or just an imx/mxs thing :) > Marc, No driver compatible name is ip specific so "ti,am33xx-can" is not required, I am not seeing any advantage if we add this name. If there are any changes required for am33xx specific in driver then we can add "ti,am33xx-can" name in driver otherwise no use. Thanks AnilKumar
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index bf5f713..ab744d6 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -177,5 +177,23 @@ compatible = "ti,omap3-wdt"; ti,hwmods = "wd_timer2"; }; + + dcan0: d_can@481cc000 { + compatible = "bosch,d_can"; + ti,hwmods = "d_can0"; + reg = <0x481cc000 0x2000>; + interrupts = <52>; + interrupt-parent = <&intc>; + status = "disabled"; + }; + + dcan1: d_can@481d0000 { + compatible = "bosch,d_can"; + ti,hwmods = "d_can1"; + reg = <0x481d0000 0x2000>; + interrupts = <55>; + interrupt-parent = <&intc>; + status = "disabled"; + }; }; };
Add Bosch D_CAN controller device tree data to AM33XX dtsi file by adding d_can device nodes with all the necessary parameters. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)