From patchwork Thu Sep 6 12:45:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1414731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4F99C40220 for ; Thu, 6 Sep 2012 13:00:31 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9bck-0006UI-GU; Thu, 06 Sep 2012 12:55:59 +0000 Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9bXc-0002jh-Ee for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 12:50:43 +0000 Received: from mail-lpp01m010-f49.google.com ([209.85.215.49]) (using TLSv1) by na3sys009aob111.postini.com ([74.125.148.12]) with SMTP ID DSNKUEicHvFCkO799tjVlJd0flvrU5ZagqKK@postini.com; Thu, 06 Sep 2012 05:50:40 PDT Received: by lagu2 with SMTP id u2so1046367lag.36 for ; Thu, 06 Sep 2012 05:50:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=81q+ome47Pize/KJgPWnoh4uy0X4kHNHcQBEVQnxdnI=; b=SpBe0f1q7/DWHBiXFOlYtRDF2S4ldDfTB/Z65JtPE8XTAQ4MC7zMw7mhgsUSg3uVT4 VEk9Pfb9U29tZaO9XVWo6sAk/LSM1zF3hK1B1mbUPwP7FisRAWPm/qybd/26nBK4uv7T qrF1HY/7zKPc7br/EWAY4Wc6c47rUGlfOI/X4pirp9isCp1mLZHBLAQk8XoshtR2MhFO VH1hmyve6G6kfQzHMtFzvj8vBzQuGfS2T87FOVY2CF31k8g9xx7yVq2xJ/wkPF/HYGiK I8gKwQgIB4+7470wKz6UN9nQASKPfjqupjcx6i/QZ6J5/mBA7Amf5aFZncoxUxXphIDT AIPw== Received: by 10.112.43.98 with SMTP id v2mr852726lbl.1.1346935836652; Thu, 06 Sep 2012 05:50:36 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id lx11sm2069607lab.4.2012.09.06.05.50.35 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 05:50:35 -0700 (PDT) From: Felipe Balbi To: Greg KH Subject: [PATCH v4 10/21] serial: omap: make sure to suspend device before remove Date: Thu, 6 Sep 2012 15:45:29 +0300 Message-Id: <1346935540-1792-11-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1346935540-1792-1-git-send-email-balbi@ti.com> References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQlwGTKV6tzjwsP9KOKiNEvhU9L4PpOlZsc4Km8Xkpm0OW92X+W+tIhOJeYNNXSfHUDckHwj X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.205 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Sourav Poddar , Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , alan@linux.intel.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org before removing the driver, let's make sure to force device into a suspended state in order to conserve power. Tested-by: Shubhrajyoti D Acked-by: Santosh Shilimkar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index c19d340..0ceca44 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1369,6 +1369,7 @@ static int serial_omap_remove(struct platform_device *dev) { struct uart_omap_port *up = platform_get_drvdata(dev); + pm_runtime_put_sync(up->dev); pm_runtime_disable(up->dev); uart_remove_one_port(&serial_omap_reg, &up->port); pm_qos_remove_request(&up->pm_qos_request);