From patchwork Thu Sep 6 12:45:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1414751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 64F29DFFCF for ; Thu, 6 Sep 2012 13:01:42 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9bdk-0007OC-AD; Thu, 06 Sep 2012 12:57:00 +0000 Received: from na3sys009aog135.obsmtp.com ([74.125.149.84]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9bXj-0002nb-EN for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 12:50:49 +0000 Received: from mail-lpp01m010-f49.google.com ([209.85.215.49]) (using TLSv1) by na3sys009aob135.postini.com ([74.125.148.12]) with SMTP ID DSNKUEicJHPMt7gVJiN76jdFKlgZXA2SM0tP@postini.com; Thu, 06 Sep 2012 05:50:47 PDT Received: by lagu2 with SMTP id u2so1046440lag.36 for ; Thu, 06 Sep 2012 05:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=CrJ6JRTlO3LmAh4WcCBVVCtSelA7MTp/IG2UA5tNiPs=; b=pm8FKJmuABkNipUhPmdGvA7TpeczU0wNo+auLsUkgEKlBzTHXlsKG/UhIkWlNK9WTS /q0ng4Hx+60oj9ZwS6qEHmbiK1TBAJSB4jyGeQKCbHP1cVcLDhAwXF8LWeAySUjE7ISp BmNVCxPd2R1+ruPIMqs02SRhMd3bmwnw2L28LfHmzJU76nPy3YFQhXRjS1RimAKk2lVh 4m6eZRgDlKFFZDecAZcHdSX4Ej9tdd1intHq4I+UwzUiKJiMN3gErMT6ZUgp89ptPhtm lsGqVECAAG88yYTag0Mf9D9C2PFARZbVlrFkUvko/nTcRLBXLF4KvRMRo5UnFNwq3hA2 8d+w== Received: by 10.152.144.134 with SMTP id sm6mr1887800lab.5.1346935843131; Thu, 06 Sep 2012 05:50:43 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id p7sm377021lbg.17.2012.09.06.05.50.41 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 05:50:42 -0700 (PDT) From: Felipe Balbi To: Greg KH Subject: [PATCH v4 12/21] serial: omap: fix sequence of pm_runtime_* calls. Date: Thu, 6 Sep 2012 15:45:31 +0300 Message-Id: <1346935540-1792-13-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1346935540-1792-1-git-send-email-balbi@ti.com> References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQlzi9K2+5BUnJXKm0prDptmU7gwGnA/OSr8zh7/jqlI3Cpx+im/4Cdk+zMjXL0+l9WGBBlx X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.84 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Nishanth Menon , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Ruchika Kharwar , Sourav Poddar , Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , alan@linux.intel.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Ruchika Kharwar pm_runtime_enable() needs to be invoked before pm_runtime_use_autosuspend(), and pm_runtime_set_autosuspend_delay() functions. Tested-by: Shubhrajyoti D Signed-off-by: Nishanth Menon Signed-off-by: Ruchika Kharwar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 99042b0..f5dcb5a 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1333,12 +1333,12 @@ static int serial_omap_probe(struct platform_device *pdev) INIT_WORK(&up->qos_work, serial_omap_uart_qos_work); platform_set_drvdata(pdev, up); + pm_runtime_enable(&pdev->dev); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, omap_up_info->autosuspend_timeout); pm_runtime_irq_safe(&pdev->dev); - pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); omap_serial_fill_features_erratas(up);