From patchwork Thu Sep 6 12:45:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1414791 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 513C03FC71 for ; Thu, 6 Sep 2012 13:03:34 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9bff-0000eM-HR; Thu, 06 Sep 2012 12:59:01 +0000 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9bXw-0002y7-0X for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 12:51:01 +0000 Received: from mail-lpp01m010-f49.google.com ([209.85.215.49]) (using TLSv1) by na3sys009aob101.postini.com ([74.125.148.12]) with SMTP ID DSNKUEicMjjrZk3mQ1DaplSfEvCVDhWxS460@postini.com; Thu, 06 Sep 2012 05:50:59 PDT Received: by lagu2 with SMTP id u2so1046601lag.36 for ; Thu, 06 Sep 2012 05:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=yE4yHCzhVoADmo/PbY+bhtDsJHB8+Uo9IhJpzYd4OL8=; b=ZaARmIMlUEsgd/czogPFVhSclBQZeURrhlWVDimrwOmweVpXxvaGZ2XbZZcXBroNSx dn7hQismKMwJxwQKz0xr+2OVb4QZHe9BtxtDTUKznvRuDiT/hmrWnjx4WTB2gpq5vy5X BBipJ0Jn6ikhijFPZCRaVjQZRLYTD5hCzSdwXj4shTQ64i6Fxvt5jzJDMMPALHFjB67I +hQamE6c8iKVNSXkIWHtbGsuqTuVgVKUpvMzcBOrCuhI1F/ZGi75+HaCDf1O9JjEZLLJ 60Y7/PVQcGJnsbH8IK4iusmQszok8JDbCNuxX4OkzSWEeaf34+LVLQY4FK1ybpKlucUQ DOSw== Received: by 10.152.108.144 with SMTP id hk16mr1903616lab.2.1346935857038; Thu, 06 Sep 2012 05:50:57 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id j3sm568360lbh.0.2012.09.06.05.50.54 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 05:50:55 -0700 (PDT) From: Felipe Balbi To: Greg KH Subject: [PATCH v4 15/21] serial: omap: unlock the port lock Date: Thu, 6 Sep 2012 15:45:34 +0300 Message-Id: <1346935540-1792-16-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1346935540-1792-1-git-send-email-balbi@ti.com> References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQnGCygHY/UEaLs0pgBKIZsjnO4p6P4QCdOqeIm8jEkL9OBnTlE8PPcN1piV6y1gJl/1jIGS X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.67 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Pavan Savoy , Santosh Shilimkar , linux-serial@vger.kernel.org, Ruchika Kharwar , Sourav Poddar , Linux OMAP Mailing List , Vijay Badawadagi , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , alan@linux.intel.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Ruchika Kharwar This patch unlocks the port lock before calling a serial_core API and re-acquires the port lock after calling it. This patch fixes a system freeze issue seen when the serial_core API uart_write_wakeup() eventually attempts to acquire the port lock already acquired by omap serial interrupt handler. Tested-by: Shubhrajyoti D Signed-off-by: Ruchika Kharwar Signed-off-by: Pavan Savoy Signed-off-by: Vijay Badawadagi Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index d244163..9e4419c 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -224,8 +224,11 @@ static void transmit_chars(struct uart_omap_port *up, unsigned int lsr) break; } while (--count > 0); - if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) + if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) { + spin_unlock(&up->port.lock); uart_write_wakeup(&up->port); + spin_lock(&up->port.lock); + } if (uart_circ_empty(xmit)) serial_omap_stop_tx(&up->port);