From patchwork Thu Sep 6 12:45:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 1414701 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 33ABD3FC71 for ; Thu, 6 Sep 2012 12:59:19 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9bbU-0005Rh-8n; Thu, 06 Sep 2012 12:54:40 +0000 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9bXW-0002ff-Mo for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 12:50:36 +0000 Received: from mail-lb0-f177.google.com ([209.85.217.177]) (using TLSv1) by na3sys009aob101.postini.com ([74.125.148.12]) with SMTP ID DSNKUEicGHd8opUfOaw7CM68R9sd1BXBQWWl@postini.com; Thu, 06 Sep 2012 05:50:34 PDT Received: by lbbgf7 with SMTP id gf7so1091711lbb.36 for ; Thu, 06 Sep 2012 05:50:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=hRZ37iCmETHWvMV3WppK4GqVYbLfT5OzbBuJGPszXok=; b=BILR72DzZyME0l6inschuj96Y8RGd32iG0wwxb/D/CjJ/oY58KZYQ9g48w6+NUqnwU 3vtNTsTKXm3BqQngipFMQ/bWvPHwJAlNLctUfFwXwSoNtPKMxc7AwW+gSQXOeQylKUDV csDKZ9ISBiMh4dq2M5hjcLdk8CpJ1KopwrQuAJm46fD+04/TlzDX/YC4y/9lQlpOU5GS 01JzeQACL4Nwf3FfFjt11E/zsdmtysY/OHxnzep7nwLUE3tbFBvmYA7JlB2tt+sJ4Eec HWSh+r5Ni6eI1cwgnOsmG2kXy88d3wlsH6H21tbGtZBsngH8XgFi9TaI41AwbW40X1oi zXWw== Received: by 10.112.28.233 with SMTP id e9mr839648lbh.43.1346935831003; Thu, 06 Sep 2012 05:50:31 -0700 (PDT) Received: from localhost (cs78217178.pp.htv.fi. [62.78.217.178]) by mx.google.com with ESMTPS id ba4sm561552lbb.14.2012.09.06.05.50.29 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 06 Sep 2012 05:50:30 -0700 (PDT) From: Felipe Balbi To: Greg KH Subject: [PATCH v4 08/21] serial: omap: set dev->drvdata before enabling pm_runtime Date: Thu, 6 Sep 2012 15:45:27 +0300 Message-Id: <1346935540-1792-9-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.7.12.rc3 In-Reply-To: <1346935540-1792-1-git-send-email-balbi@ti.com> References: <20120906122948.GC29202@arwen.pp.htv.fi> <1346935540-1792-1-git-send-email-balbi@ti.com> X-Gm-Message-State: ALoCoQkslmSUu1DMVGuBLohj+0NvO2Yz0+8AcBkBwbea6i+Anf5+nw8xlRYIrhZctwJD64/MIoAi X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.67 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Kevin Hilman , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , Santosh Shilimkar , linux-serial@vger.kernel.org, Sourav Poddar , Linux OMAP Mailing List , Shubhrajyoti Datta , Linux ARM Kernel Mailing List , alan@linux.intel.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org by the time we call our first pm_runtme_get_sync() after enable pm_runtime, our resume method might be called. To avoid problems, we must make sure that our dev->drvdata is set correctly before our resume method gets called. Tested-by: Shubhrajyoti D Acked-by: Santosh Shilimkar Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index b2043df..8a696a4 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1333,6 +1333,7 @@ static int serial_omap_probe(struct platform_device *pdev) serial_omap_uart_wq = create_singlethread_workqueue(up->name); INIT_WORK(&up->qos_work, serial_omap_uart_qos_work); + platform_set_drvdata(pdev, up); pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, omap_up_info->autosuspend_timeout); @@ -1352,7 +1353,6 @@ static int serial_omap_probe(struct platform_device *pdev) pm_runtime_mark_last_busy(up->dev); pm_runtime_put_autosuspend(up->dev); - platform_set_drvdata(pdev, up); return 0; err_add_port: