From patchwork Thu Sep 6 15:21:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Kurtz X-Patchwork-Id: 1417111 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 1B7973FC71 for ; Thu, 6 Sep 2012 16:44:22 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9esc-0008N0-Nw; Thu, 06 Sep 2012 16:24:34 +0000 Received: from mail-yw0-f73.google.com ([209.85.213.73]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9dtO-0000yZ-V4 for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 15:21:21 +0000 Received: by yhpp61 with SMTP id p61so179724yhp.0 for ; Thu, 06 Sep 2012 08:21:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=JdXlC9lYJRuNpjE5u/n7xA0GB0P0KceCo5wB2ZNvSyk=; b=Y3Z3ynYV6SDh3V82/47C7g6xkfAIUq+FVD36zG2je7MWeeuPPR6caTeH3W4vQAgJf6 pm7kb55LdGghArbS4zbZ7FWp0qn6qI9IcSX75IfQv/E07fAitqWfVuXEDwO/hsMy8Q7W UtKsUjhlpfvBfTKmBs96YZlswPbrif3G9XN8Uvl/WYKLSVMR1FEhDpaFUzOMJ2FvDUSN WnJHy9FoiSy4QXqbn1VARtwQbH9buVrBWKtbNgl7MUkoeOK3gVRNHdhguHFPr381KdYU 4uvPGhTVnKP2LpD3fAdssq/tDqFbU6kMlniO2ok7DuXcyJlh9pm2Ly7J90sXLw0tYjp6 1yJA== Received: by 10.236.91.229 with SMTP id h65mr1389859yhf.24.1346944875324; Thu, 06 Sep 2012 08:21:15 -0700 (PDT) Received: by 10.236.91.229 with SMTP id h65mr1389844yhf.24.1346944875192; Thu, 06 Sep 2012 08:21:15 -0700 (PDT) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id l23si672159yhk.6.2012.09.06.08.21.15 (version=TLSv1/SSLv3 cipher=AES128-SHA); Thu, 06 Sep 2012 08:21:15 -0700 (PDT) Received: from puck.tpe.corp.google.com (puck.tpe.corp.google.com [172.30.210.35]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id F0595100047; Thu, 6 Sep 2012 08:21:14 -0700 (PDT) Received: by puck.tpe.corp.google.com (Postfix, from userid 116377) id 1A71D80A32; Thu, 6 Sep 2012 23:21:13 +0800 (CST) From: Daniel Kurtz To: Kukjin Kim , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15 Date: Thu, 6 Sep 2012 23:21:04 +0800 Message-Id: <1346944864-12434-1-git-send-email-djkurtz@chromium.org> X-Mailer: git-send-email 1.7.7.3 X-Gm-Message-State: ALoCoQkwu1q/h7yJwrlqvdLjpAmWyzRa9AGEN2j9EqhWYdQPvf5n7O3qmkVDbjLptVPuaujZZO/RDQQDqug9U0JSaesOCMHNZ7DM4xKp6Vytq3hoNqLvo4w9YuAgh3V62j63C3JQ87tEYh4E7dHcYaEe8n8aV55jbrPWv0+exlZh2eSBaRDdnMHAoPvsLrPyifDPHCxjrs+694HjlFL0kfFjCMpcm7fvYw== X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.73 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: olofj@chromium.org, Thomas Abraham , dianders@chromium.org, Daniel Kurtz X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org chained_irq_enter/exit() already mask&ack/unmask the chained interrupt. There is no need to also explicitly do it in the handler. Signed-off-by: Daniel Kurtz Acked-by: Doug Anderson --- arch/arm/mach-exynos/common.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index 4eb39cd..0a85aec 100644 --- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos/common.c @@ -965,14 +965,7 @@ static void exynos_irq_eint0_15(unsigned int irq, struct irq_desc *desc) struct irq_chip *chip = irq_get_chip(irq); chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); - generic_handle_irq(*irq_data); - - chip->irq_unmask(&desc->irq_data); chained_irq_exit(chip, desc); }