| Message ID | 1347016499-29354-12-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > Here we add the skeleton nodes for each of the known I2C sub-devices > currently registered on ST-Ericsson's HREF Development Platform. We > will fill these nodes in turn as the drivers are enabled for Device > Tree. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Can't we have it the other way around (discussing patch ordering with Arnd simultaneously), so you first add the DT support to the subdevices, then add the more complete nodes to the device tree? And if you put in a device tree like this, will these devices not collide with the ones that are currently supplied from the boardfiles? I'm a bit confused here, maybe I'm not smart enough to understand this... Yours, Linus Walleij
On Mon, Sep 10, 2012 at 04:34:15AM -0700, Linus Walleij wrote: > On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > Here we add the skeleton nodes for each of the known I2C sub-devices > > currently registered on ST-Ericsson's HREF Development Platform. We > > will fill these nodes in turn as the drivers are enabled for Device > > Tree. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Can't we have it the other way around (discussing patch ordering > with Arnd simultaneously), so you first add the DT support to the > subdevices, then add the more complete nodes to the device tree? > > And if you put in a device tree like this, will these devices > not collide with the ones that are currently supplied from > the boardfiles? I'm a bit confused here, maybe I'm not smart > enough to understand this... Okay, I've reordered the patch-set to address these possible issues.
On Mon, Sep 10, 2012 at 04:34:15AM -0700, Linus Walleij wrote: > On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > Here we add the skeleton nodes for each of the known I2C sub-devices > > currently registered on ST-Ericsson's HREF Development Platform. We > > will fill these nodes in turn as the drivers are enabled for Device > > Tree. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Can't we have it the other way around (discussing patch ordering > with Arnd simultaneously), so you first add the DT support to the > subdevices, then add the more complete nodes to the device tree? > > And if you put in a device tree like this, will these devices > not collide with the ones that are currently supplied from > the boardfiles? I'm a bit confused here, maybe I'm not smart > enough to understand this... We finished this conversation about future ordering didn't we? Would you mind reviewing the code in the patch please, as it's still missing your Ack, so can't send.
On Fri, Sep 14, 2012 at 10:47 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, Sep 10, 2012 at 04:34:15AM -0700, Linus Walleij wrote: >> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: >> >> > Here we add the skeleton nodes for each of the known I2C sub-devices >> > currently registered on ST-Ericsson's HREF Development Platform. We >> > will fill these nodes in turn as the drivers are enabled for Device >> > Tree. >> > >> > Signed-off-by: Lee Jones <lee.jones@linaro.org> >> >> Can't we have it the other way around (discussing patch ordering >> with Arnd simultaneously), so you first add the DT support to the >> subdevices, then add the more complete nodes to the device tree? >> >> And if you put in a device tree like this, will these devices >> not collide with the ones that are currently supplied from >> the boardfiles? I'm a bit confused here, maybe I'm not smart >> enough to understand this... > > Okay, I've reordered the patch-set to address these possible issues. OK sorry for delay, I've been patch-swamped... Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts index 7f0dddb..ec9ec4f 100644 --- a/arch/arm/boot/dts/hrefv60plus.dts +++ b/arch/arm/boot/dts/hrefv60plus.dts @@ -95,5 +95,31 @@ ssp@80002000 { status = "okay"; }; + + i2c@80004000 { + tc3589x@42 { + compatible = "tc3589x"; + reg = <0x42>; + }; + tps61052@33 { + compatible = "tps61052"; + reg = <0x33>; + }; + }; + + i2c@80128000 { + lp5521@0x33 { + compatible = "lp5521"; + reg = <0x33>; + }; + lp5521@0x34 { + compatible = "lp5521"; + reg = <0x34>; + }; + bh1780@0x29 { + compatible = "rohm,bh1780gli"; + reg = <0x33>; + }; + }; }; };
Here we add the skeleton nodes for each of the known I2C sub-devices currently registered on ST-Ericsson's HREF Development Platform. We will fill these nodes in turn as the drivers are enabled for Device Tree. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/hrefv60plus.dts | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)