| Message ID | 1347016499-29354-7-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > This patch enables the two important MSP devices for ST-Ericsson's > hardware reference development board. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/hrefv60plus.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts > index 62b2ac1..4f0aee8 100644 > --- a/arch/arm/boot/dts/hrefv60plus.dts > +++ b/arch/arm/boot/dts/hrefv60plus.dts > @@ -77,5 +77,13 @@ > > status = "okay"; > }; > + > + msp1: msp@80124000 { > + status = "okay"; > + }; > + > + msp3: msp@80125000 { > + status = "okay"; > + }; > }; > }; Does this really "enable" the MSPs as the title claims? Aren's there any kind of bindings needed, not even a register base? Yours, Linus Walleij
On Mon, Sep 10, 2012 at 02:53:45AM -0700, Linus Walleij wrote: > On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > This patch enables the two important MSP devices for ST-Ericsson's > > hardware reference development board. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/hrefv60plus.dts | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts > > index 62b2ac1..4f0aee8 100644 > > --- a/arch/arm/boot/dts/hrefv60plus.dts > > +++ b/arch/arm/boot/dts/hrefv60plus.dts > > @@ -77,5 +77,13 @@ > > > > status = "okay"; > > }; > > + > > + msp1: msp@80124000 { > > + status = "okay"; > > + }; > > + > > + msp3: msp@80125000 { > > + status = "okay"; > > + }; > > }; > > }; > > Does this really "enable" the MSPs as the title claims? Yes they do. > Aren's there any kind of bindings needed, not even a > register base? All that information is in the "disabled" node contained in .dtsi file. + msp0: msp@80123000 { + compatible = "stericsson,ux500-msp-i2s"; + reg = <0x80123000 0x1000>; + interrupts = <0 31 0x4>; + v-ape-supply = <&db8500_vape_reg>; + status = "disabled"; Then this patch "enable"s it (as the title suggests). :)
On Fri, Sep 14, 2012 at 11:23 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, Sep 10, 2012 at 02:53:45AM -0700, Linus Walleij wrote: >> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: >> >> > + msp3: msp@80125000 { >> > + status = "okay"; >> > + }; >> > }; >> > }; >> >> Does this really "enable" the MSPs as the title claims? > > Yes they do. > >> Aren's there any kind of bindings needed, not even a >> register base? > > All that information is in the "disabled" node contained in .dtsi file. Argh it's hard to read DT patches without parsing through all the .dtsi:s in your head first ... Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts index 62b2ac1..4f0aee8 100644 --- a/arch/arm/boot/dts/hrefv60plus.dts +++ b/arch/arm/boot/dts/hrefv60plus.dts @@ -77,5 +77,13 @@ status = "okay"; }; + + msp1: msp@80124000 { + status = "okay"; + }; + + msp3: msp@80125000 { + status = "okay"; + }; }; };
This patch enables the two important MSP devices for ST-Ericsson's hardware reference development board. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/hrefv60plus.dts | 8 ++++++++ 1 file changed, 8 insertions(+)