diff mbox

[07/19] ARM: ux500: Add all encompassing sound node to the HREF Device Tree

Message ID 1347016499-29354-8-git-send-email-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Lee Jones Sept. 7, 2012, 11:14 a.m. UTC
This is where we link together all of the SoC sound components for
a given platform. This all encompassing sound node is only found
in the very lowest hierarchical DTS file, since the component mix may
well change from board variant to board variant.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/hrefv60plus.dts |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Linus Walleij Sept. 10, 2012, 9:56 a.m. UTC | #1
On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote:

> This is where we link together all of the SoC sound components for
> a given platform. This all encompassing sound node is only found
> in the very lowest hierarchical DTS file, since the component mix may
> well change from board variant to board variant.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/hrefv60plus.dts |    7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts
> index 4f0aee8..d8ed29e 100644
> --- a/arch/arm/boot/dts/hrefv60plus.dts
> +++ b/arch/arm/boot/dts/hrefv60plus.dts
> @@ -78,6 +78,13 @@
>                         status = "okay";
>                 };
>
> +               sound {
> +                       compatible = "stericsson,snd-soc-mop500";
> +
> +                       stericsson,cpu-dai = <&msp1 &msp3>;
> +                       stericsson,audio-codec = <&codec>;

Where is this codec coming from?

It's certainly not in the linux-next tree...

This is another of these patches that I prefer if Ola
or Roger or even Mark could comment on, I really don't know
too much about ASoC DT bindings...

Yours,
Linus Walleij
Lee Jones Sept. 14, 2012, 9:20 a.m. UTC | #2
On Mon, Sep 10, 2012 at 02:56:20AM -0700, Linus Walleij wrote:
> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote:
> 
> > This is where we link together all of the SoC sound components for
> > a given platform. This all encompassing sound node is only found
> > in the very lowest hierarchical DTS file, since the component mix may
> > well change from board variant to board variant.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  arch/arm/boot/dts/hrefv60plus.dts |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts
> > index 4f0aee8..d8ed29e 100644
> > --- a/arch/arm/boot/dts/hrefv60plus.dts
> > +++ b/arch/arm/boot/dts/hrefv60plus.dts
> > @@ -78,6 +78,13 @@
> >                         status = "okay";
> >                 };
> >
> > +               sound {
> > +                       compatible = "stericsson,snd-soc-mop500";
> > +
> > +                       stericsson,cpu-dai = <&msp1 &msp3>;
> > +                       stericsson,audio-codec = <&codec>;
> 
> Where is this codec coming from?
> 
> It's certainly not in the linux-next tree...

No, I'm holding it locally.

My Audio patch-set is still awaiting Ola's Acks (6 patches)

... unless they're further down my mailbox.

/me keeps reading.

> This is another of these patches that I prefer if Ola
> or Roger or even Mark could comment on, I really don't know
> too much about ASoC DT bindings...
diff mbox

Patch

diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts
index 4f0aee8..d8ed29e 100644
--- a/arch/arm/boot/dts/hrefv60plus.dts
+++ b/arch/arm/boot/dts/hrefv60plus.dts
@@ -78,6 +78,13 @@ 
 			status = "okay";
 		};
 
+		sound {
+			compatible = "stericsson,snd-soc-mop500";
+
+			stericsson,cpu-dai = <&msp1 &msp3>;
+			stericsson,audio-codec = <&codec>;
+		};
+
 		msp1: msp@80124000 {
 			status = "okay";
 		};