| Message ID | 1347343932-3656-1-git-send-email-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Kishon, On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: > Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is > connected to ocp2scp, omap-usb2 dt data is added as a child node > of ocp2scp. Could you add more details about the omap-usb2? You must update the Documentation binding with that compatible name. Is it already part of the driver serie? The MUSB driver is referring to "ti,musb-omap2430" only. > > Acked-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > Applies on > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next > arch/arm/boot/dts/omap4.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 8a780b2..bdc21f1 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -302,6 +302,11 @@ > #size-cells = <1>; > ranges; > ti,hwmods = "ocp2scp_usb_phy"; There is no ocp2scp_usb_phy in the current omap4.dtsi? What base did you used? You have to use lo/devel-dt branch as a base. All the latest DTS patches an in there for 3.7. Regards, Benoit > + usb2phy@4a0ad080 { > + compatible = "ti,omap-usb2"; > + reg = <0x4a0ad080 0x58>, > + <0x4a002300 0x4>; > + }; > }; > }; > }; >
Hi, On Tue, Sep 11, 2012 at 1:53 PM, Benoit Cousson <b-cousson@ti.com> wrote: > Hi Kishon, > > On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: >> Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is >> connected to ocp2scp, omap-usb2 dt data is added as a child node >> of ocp2scp. > > Could you add more details about the omap-usb2? I think information about omap-usb2 driver is added in *usb: phy: add a new driver for omap usb2 phy.*. Do you want the same thing to be added here? > > You must update the Documentation binding with that compatible name. Yes. It's part of *usb: phy: add a new driver for omap usb2 phy.* > Is it already part of the driver serie? The MUSB driver is referring to > "ti,musb-omap2430" only. Will correct the Documentation for MUSB. Thanks Kishon
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 8a780b2..bdc21f1 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -302,6 +302,11 @@ #size-cells = <1>; ranges; ti,hwmods = "ocp2scp_usb_phy"; + usb2phy@4a0ad080 { + compatible = "ti,omap-usb2"; + reg = <0x4a0ad080 0x58>, + <0x4a002300 0x4>; + }; }; }; };