diff mbox

[PATCHv7,19/23] i2c: omap: always return IRQ_HANDLED

Message ID 1347356538-23835-20-git-send-email-shubhrajyoti@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shubhrajyoti Datta Sept. 11, 2012, 9:42 a.m. UTC 
From: Felipe Balbi <balbi@ti.com>

even if our clocks are disabled, we still
handled the IRQ, so we should return IRQ_HANDLED.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/i2c/busses/i2c-omap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Wolfram Sang Sept. 11, 2012, 9:53 p.m. UTC | #1 
On Tue, Sep 11, 2012 at 03:12:14PM +0530, Shubhrajyoti D wrote:
> From: Felipe Balbi <balbi@ti.com>
> 
> even if our clocks are disabled, we still
> handled the IRQ, so we should return IRQ_HANDLED.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>

Can't we just drop this patch since the code gets removed soon anyhow?
Or is patch 20/23 changing something I don't see yet?
Shubhrajyoti Datta Sept. 12, 2012, 6:42 a.m. UTC | #2 
On Wednesday 12 September 2012 03:23 AM, Wolfram Sang wrote:
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> Can't we just drop this patch since the code gets removed soon anyhow?
> Or is patch 20/23 changing something I don't see yet?
yes it is dropped will update.
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 498a462..4a696bd 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -862,7 +862,7 @@  omap_i2c_isr(int this_irq, void *dev_id)
 	int err = 0, count = 0;
 
 	if (pm_runtime_suspended(dev->dev))
-		return IRQ_NONE;
+		return IRQ_HANDLED;
 
 	do {
 		bits = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);