| Message ID | 1347860103-4141-17-git-send-email-shawn.guo@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 17, 2012 at 01:34:45PM +0800, Shawn Guo wrote: > #include <linux/platform_data/asoc-imx-ssi.h> > -#include <mach/hardware.h> This doesn't apply - there's no platform data header for imx-ssi at the minute (and I don't see a patch in this series related to that in the series). I checked -next and there doesn't seem to be anything via a non-ASoC tree either.
On Monday 17 September 2012, Mark Brown wrote: > On Mon, Sep 17, 2012 at 01:34:45PM +0800, Shawn Guo wrote: > > > #include <linux/platform_data/asoc-imx-ssi.h> > > -#include <mach/hardware.h> > > This doesn't apply - there's no platform data header for imx-ssi at the > minute (and I don't see a patch in this series related to that in the > series). I checked -next and there doesn't seem to be anything via a > non-ASoC tree either. > It's in my testing/platform-data series, and will be in linux-next in a few days. Arnd
On Mon, Sep 17, 2012 at 02:30:35PM +0000, Arnd Bergmann wrote: > On Monday 17 September 2012, Mark Brown wrote: > > On Mon, Sep 17, 2012 at 01:34:45PM +0800, Shawn Guo wrote: > > > #include <linux/platform_data/asoc-imx-ssi.h> > > > -#include <mach/hardware.h> > > This doesn't apply - there's no platform data header for imx-ssi at the > > minute (and I don't see a patch in this series related to that in the > > series). I checked -next and there doesn't seem to be anything via a > > non-ASoC tree either. > It's in my testing/platform-data series, and will be in linux-next in > a few days. Hrm, that seems odd - why are we adding platform data to the driver?
On Wednesday 19 September 2012, Mark Brown wrote: > On Mon, Sep 17, 2012 at 02:30:35PM +0000, Arnd Bergmann wrote: > > On Monday 17 September 2012, Mark Brown wrote: > > > On Mon, Sep 17, 2012 at 01:34:45PM +0800, Shawn Guo wrote: > > > > > #include <linux/platform_data/asoc-imx-ssi.h> > > > > -#include <mach/hardware.h> > > > > This doesn't apply - there's no platform data header for imx-ssi at the > > > minute (and I don't see a patch in this series related to that in the > > > series). I checked -next and there doesn't seem to be anything via a > > > non-ASoC tree either. > > > It's in my testing/platform-data series, and will be in linux-next in > > a few days. > > Hrm, that seems odd - why are we adding platform data to the driver? We're not adding it, we just rename the header file from mach/imx.h to linux/platform-data/asoc-imx-ssi.h, along with 94 other header files that get moved to the same directory. Arnd
On Wed, Sep 19, 2012 at 08:01:23AM +0000, Arnd Bergmann wrote: > On Wednesday 19 September 2012, Mark Brown wrote: > > Hrm, that seems odd - why are we adding platform data to the driver? > We're not adding it, we just rename the header file from mach/imx.h > to linux/platform-data/asoc-imx-ssi.h, along with 94 other header files > that get moved to the same directory. Ah, that stuff. I'd not really registered it as actually adding platform data to be honest, obviously the series was too big to read in detail.
diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c index e6a17ba..1a28f15 100644 --- a/sound/soc/fsl/imx-ssi.c +++ b/sound/soc/fsl/imx-ssi.c @@ -48,7 +48,6 @@ #include <sound/soc.h> #include <linux/platform_data/asoc-imx-ssi.h> -#include <mach/hardware.h> #include "imx-ssi.h"
The inclusion of mach/hardware.h is not used by the driver at all. Remove it. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: alsa-devel@alsa-project.org --- sound/soc/fsl/imx-ssi.c | 1 - 1 file changed, 1 deletion(-)