| Message ID | 1347939042.15578.1.camel@phoenix (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote: > This fixes below build error when CONFIG_LEDS_CLASS is not set. > > LD init/built-in.o > arch/arm/plat-omap/built-in.o: In function `fpga_probe': > arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' > make: *** [vmlinux] Error 1 > Thanks for posting this. But I think Tony has already fixed it in mainline: -- commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4 Author: Tony Lindgren <tony@atomide.com> Date: Wed Sep 15 10:18:51 2010 -0700 omap: Fix compile dependency to LEDS_CLASS If we LEDS_CLASS is not selected, we will get undefined reference to `led_classdev_register'. Signed-off-by: Tony Lindgren <tony@atomide.com> -- -Bryan > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > arch/arm/plat-omap/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig > index ca83a76..c262781 100644 > --- a/arch/arm/plat-omap/Kconfig > +++ b/arch/arm/plat-omap/Kconfig > @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES > > config OMAP_DEBUG_LEDS > def_bool y if NEW_LEDS > + select LEDS_CLASS > depends on OMAP_DEBUG_DEVICES > > config POWER_AVS_OMAP > -- > 1.7.9.5 > > >
2012/9/18 Bryan Wu <bryan.wu@canonical.com>: > On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote: >> This fixes below build error when CONFIG_LEDS_CLASS is not set. >> >> LD init/built-in.o >> arch/arm/plat-omap/built-in.o: In function `fpga_probe': >> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' >> make: *** [vmlinux] Error 1 >> > > Thanks for posting this. But I think Tony has already fixed it in mainline: > -- > commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4 > Author: Tony Lindgren <tony@atomide.com> > Date: Wed Sep 15 10:18:51 2010 -0700 > > omap: Fix compile dependency to LEDS_CLASS > > If we LEDS_CLASS is not selected, we will get undefined reference > to `led_classdev_register'. > > Signed-off-by: Tony Lindgren <tony@atomide.com> Commit 359f64f7b was commited on Sep 15 2010. This patch is against current linux-next tree. I got the build error on linux-next tree (next-20120917). Regards, Axel
On Tue, Sep 18, 2012 at 2:49 PM, Axel Lin <axel.lin@gmail.com> wrote: > 2012/9/18 Bryan Wu <bryan.wu@canonical.com>: >> On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote: >>> This fixes below build error when CONFIG_LEDS_CLASS is not set. >>> >>> LD init/built-in.o >>> arch/arm/plat-omap/built-in.o: In function `fpga_probe': >>> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' >>> make: *** [vmlinux] Error 1 >>> >> >> Thanks for posting this. But I think Tony has already fixed it in mainline: >> -- >> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4 >> Author: Tony Lindgren <tony@atomide.com> >> Date: Wed Sep 15 10:18:51 2010 -0700 >> >> omap: Fix compile dependency to LEDS_CLASS >> >> If we LEDS_CLASS is not selected, we will get undefined reference >> to `led_classdev_register'. >> >> Signed-off-by: Tony Lindgren <tony@atomide.com> > > Commit 359f64f7b was commited on Sep 15 2010. > This patch is against current linux-next tree. > I got the build error on linux-next tree (next-20120917). > Obviously, linux-next is not updated to latest mainline, -:D Thanks,
* Bryan Wu <bryan.wu@canonical.com> [120918 01:03]: > On Tue, Sep 18, 2012 at 2:49 PM, Axel Lin <axel.lin@gmail.com> wrote: > > 2012/9/18 Bryan Wu <bryan.wu@canonical.com>: > >> On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote: > >>> This fixes below build error when CONFIG_LEDS_CLASS is not set. > >>> > >>> LD init/built-in.o > >>> arch/arm/plat-omap/built-in.o: In function `fpga_probe': > >>> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' > >>> make: *** [vmlinux] Error 1 > >>> > >> > >> Thanks for posting this. But I think Tony has already fixed it in mainline: > >> -- > >> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4 > >> Author: Tony Lindgren <tony@atomide.com> > >> Date: Wed Sep 15 10:18:51 2010 -0700 > >> > >> omap: Fix compile dependency to LEDS_CLASS > >> > >> If we LEDS_CLASS is not selected, we will get undefined reference > >> to `led_classdev_register'. > >> > >> Signed-off-by: Tony Lindgren <tony@atomide.com> > > > > Commit 359f64f7b was commited on Sep 15 2010. > > This patch is against current linux-next tree. > > I got the build error on linux-next tree (next-20120917). > > > > Obviously, linux-next is not updated to latest mainline, -:D Thanks I'll apply this to fixes. Regards, Tony
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index ca83a76..c262781 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES config OMAP_DEBUG_LEDS def_bool y if NEW_LEDS + select LEDS_CLASS depends on OMAP_DEBUG_DEVICES config POWER_AVS_OMAP
This fixes below build error when CONFIG_LEDS_CLASS is not set. LD init/built-in.o arch/arm/plat-omap/built-in.o: In function `fpga_probe': arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin <axel.lin@gmail.com> --- arch/arm/plat-omap/Kconfig | 1 + 1 file changed, 1 insertion(+)