From patchwork Thu Sep 20 08:51:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 1483341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id C747ADF2D2 for ; Thu, 20 Sep 2012 08:54:36 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEcV1-0004hm-UT; Thu, 20 Sep 2012 08:52:44 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TEcUc-0004cQ-RW for linux-arm-kernel@lists.infradead.org; Thu, 20 Sep 2012 08:52:19 +0000 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAN00CU64MYFC50@mailout4.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 20 Sep 2012 17:52:18 +0900 (KST) X-AuditID: cbfee61a-b7f726d000000ec7-ad-505ad9427247 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A9.9E.03783.249DA505; Thu, 20 Sep 2012 17:52:18 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MAN001S64MRTC90@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 20 Sep 2012 17:52:18 +0900 (KST) From: Tomasz Figa To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/6] pinctrl: exynos: Fix typos in gpio/wkup _irq_mask Date: Thu, 20 Sep 2012 10:51:40 +0200 Message-id: <1348131104-24828-3-git-send-email-t.figa@samsung.com> X-Mailer: git-send-email 1.7.10 In-reply-to: <1348131104-24828-1-git-send-email-t.figa@samsung.com> References: <1348131104-24828-1-git-send-email-t.figa@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIJMWRmVeSWpSXmKPExsVy+t9jQV2nm1EBBv++SllsenyN1YHRY/OS +gDGKC6blNSczLLUIn27BK6MV++rC+6yVxy+dJmxgXENWxcjJ4eEgInEzQs97BC2mMSFe+uB 4lwcQgLTGSWOnO1ngXA2M0kcebmSEaSKTUBN4nPDI7BuEQENiSldj9lBipgF9jFKTL20mwUk ISzgJjH77mpmEJtFQFXi7tmbQM0cHLwCThJXH/hBbJOXeHq/D2wOp4CzxKkHnWDlQkAlcy+v ZpvAyLuAkWEVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRrDHn0ntYFzZYHGIUYCDUYmHt3F5 VIAQa2JZcWXuIUYJDmYlEd6NE4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeYU/BQYICaQnlqRm p6YWpBbBZJk4OKUaGFtt31QJvOkVVN3Lwn1RWcUq1q2U/fhXXR+X9/MvZ6c3283l54n+vH7v y46GAye79vRsuL7OwOXVv12WzD35uk4di6R2NKlMNhNd+eBcmJK2+Ik9up63nbLOrJ4gzJ/x wv7yI7eLX/w4dnBGLuY6tfuh8oasZLGVoXeeLWhc7DdfeR4/W0mfpxJLcUaioRZzUXEiAE6c HdH0AQAA X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.4 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.34 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: kgene.kim@samsung.com, linus.walleij@linaro.org, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, thomas.abraham@linaro.org, t.figa@samsung.com, m.szyprowski@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org To mask GPIO/wakeup IRQ, the corresponding bit in mask register has to be set. Signed-off-by: Tomasz Figa Signed-off-by: Kyungmin Park --- drivers/pinctrl/pinctrl-exynos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c index c2fa85f..46cd637 100644 --- a/drivers/pinctrl/pinctrl-exynos.c +++ b/drivers/pinctrl/pinctrl-exynos.c @@ -58,7 +58,7 @@ static void exynos_gpio_irq_mask(struct irq_data *irqd) unsigned long mask; mask = readl(d->virt_base + reg_mask); - mask |= ~(1 << edata->pin); + mask |= 1 << edata->pin; writel(mask, d->virt_base + reg_mask); } @@ -290,7 +290,7 @@ static void exynos_wkup_irq_mask(struct irq_data *irqd) unsigned long mask; mask = readl(d->virt_base + reg_mask); - mask &= ~(1 << pin); + mask |= 1 << pin; writel(mask, d->virt_base + reg_mask); }