diff mbox

[v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Message ID 1348561590-13361-1-git-send-email-yegorslists@googlemail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yegor Yefremov Sept. 25, 2012, 8:26 a.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
of consistent DMA memory (da8xx frame buffer driver).

Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
	v2: fix SA1111 breakage

 arch/arm/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Russell King - ARM Linux Sept. 25, 2012, 8:32 a.m. UTC | #1 
On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> of consistent DMA memory (da8xx frame buffer driver).

Okay, so the patch description says "This needs to be 12 on this platform".

>  config FORCE_MAX_ZONEORDER
> -	int "Maximum zone order" if ARCH_SHMOBILE
> -	range 11 64 if ARCH_SHMOBILE
> +	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
> +	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX

but you leave it up to the user to select something that may not be
suitable.  Wouldn't _just_ adding:

	default "12" if SOC_AM33XX

after the "range", and making no other changes be good enough and match
what the patch description says?
Yegor Yefremov Sept. 25, 2012, 8:46 a.m. UTC | #2 
On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
> 
> Okay, so the patch description says "This needs to be 12 on this platform".
> 
>>  config FORCE_MAX_ZONEORDER
>> -	int "Maximum zone order" if ARCH_SHMOBILE
>> -	range 11 64 if ARCH_SHMOBILE
>> +	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
>> +	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> 
> but you leave it up to the user to select something that may not be
> suitable.  Wouldn't _just_ adding:
> 
> 	default "12" if SOC_AM33XX
> 
> after the "range", and making no other changes be good enough and match
> what the patch description says?

You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?

Patch sent.

Yegor
Tony Lindgren Sept. 25, 2012, 3:27 p.m. UTC | #3 
* Yegor Yefremov <yegor_sub1@visionsystems.de> [120925 01:47]:
> On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> > On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists@googlemail.com wrote:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >>
> >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> >> of consistent DMA memory (da8xx frame buffer driver).
> > 
> > Okay, so the patch description says "This needs to be 12 on this platform".
> > 
> >>  config FORCE_MAX_ZONEORDER
> >> -	int "Maximum zone order" if ARCH_SHMOBILE
> >> -	range 11 64 if ARCH_SHMOBILE
> >> +	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
> >> +	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> > 
> > but you leave it up to the user to select something that may not be
> > suitable.  Wouldn't _just_ adding:
> > 
> > 	default "12" if SOC_AM33XX
> > 
> > after the "range", and making no other changes be good enough and match
> > what the patch description says?
> 
> You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?

Sure.

Tony
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2f88d8d..b5f242e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1766,8 +1766,8 @@  config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
 	default "9" if SA1111
 	default "11"
 	help