diff mbox

[1/3] ARM: dts: imx53-qsb: Use pinctrl for gpio-led

Message ID 1348702057-2351-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Sept. 26, 2012, 11:27 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver 
has pinctrl support, so setup the gpio led pin via pinctrl and avoid the 
following warning:

leds-gpio leds.2: pins are not configured from the driver

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx53-qsb.dts |    8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Marek Vasut Sept. 26, 2012, 11:59 p.m. UTC | #1 
Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led
> driver has pinctrl support, so setup the gpio led pin via pinctrl and
> avoid the following warning:
> 
> leds-gpio leds.2: pins are not configured from the driver
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Reviewed-by: Marek Vasut <marex@denx.de>

> ---
>  arch/arm/boot/dts/imx53-qsb.dts |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts
> b/arch/arm/boot/dts/imx53-qsb.dts index 08948af..5bae4c7 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -60,10 +60,16 @@
>  							697  0x80000000	/* 
MX53_PAD_EIM_DA12__GPIO3_12 */
>  							701  0x80000000	/* 
MX53_PAD_EIM_DA13__GPIO3_13 */
>  							868  0x80000000	/* 
MX53_PAD_PATA_DA_0__GPIO7_6 */
> +						>;
> +					};
> +
> +					led_pin_gpio7_7: led_gpio7_7@0 {
> +						fsl,pins = <
>  							873  0x80000000	/* 
MX53_PAD_PATA_DA_1__GPIO7_7 */
> 
>  						>;
> 
>  					};
>  				};
> +
>  			};
> 
>  			uart1: serial@53fbc000 {
> @@ -216,6 +222,8 @@
> 
>  	leds {
>  		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pin_gpio7_7>;
> 
>  		user {
>  			label = "Heartbeat";

Best regards,
Marek Vasut
Shawn Guo Oct. 6, 2012, 3:35 p.m. UTC | #2 
On Wed, Sep 26, 2012 at 08:27:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 8fe4554f (leds: leds-gpio: adopt pinctrl support) gpio-led driver 
> has pinctrl support, so setup the gpio led pin via pinctrl and avoid the 
> following warning:
> 
> leds-gpio leds.2: pins are not configured from the driver
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Queued first 2 patches for 3.8, and leave patch #3 to Sascha.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 08948af..5bae4c7 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -60,10 +60,16 @@ 
 							697  0x80000000	/* MX53_PAD_EIM_DA12__GPIO3_12 */
 							701  0x80000000	/* MX53_PAD_EIM_DA13__GPIO3_13 */
 							868  0x80000000	/* MX53_PAD_PATA_DA_0__GPIO7_6 */
+						>;
+					};
+
+					led_pin_gpio7_7: led_gpio7_7@0 {
+						fsl,pins = <
 							873  0x80000000	/* MX53_PAD_PATA_DA_1__GPIO7_7 */
 						>;
 					};
 				};
+
 			};
 
 			uart1: serial@53fbc000 {
@@ -216,6 +222,8 @@ 
 
 	leds {
 		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&led_pin_gpio7_7>;
 
 		user {
 			label = "Heartbeat";