| Message ID | 1348734970-20050-1-git-send-email-Barry.Song@csr.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2012-09-27 at 16:36 +0800, Barry Song wrote: > From: Barry Song <Baohua.Song@csr.com> > > list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued) > undefined, we either should change it to: > list_move_tail(schan->queued.next, &schan->active) > or > list_move_tail(&sdesc->node, &schan->active) > > Signed-off-by: Barry Song <Baohua.Song@csr.com> > --- > drivers/dma/sirf-dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c > index 35a329d..c439489 100644 > --- a/drivers/dma/sirf-dma.c > +++ b/drivers/dma/sirf-dma.c > @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan) > sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc, > node); > /* Move the first queued descriptor to active list */ > - list_move_tail(&schan->queued, &schan->active); > + list_move_tail(&sdesc->node, &schan->active); > > /* Start the DMA transfer */ > writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 + applied thanks
diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c index 35a329d..c439489 100644 --- a/drivers/dma/sirf-dma.c +++ b/drivers/dma/sirf-dma.c @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan) sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc, node); /* Move the first queued descriptor to active list */ - list_move_tail(&schan->queued, &schan->active); + list_move_tail(&sdesc->node, &schan->active); /* Start the DMA transfer */ writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +