| Message ID | 1348836795-4783-3-git-send-email-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: > Before accessing any register, runtime API's should be invoked to enable > the clocks. runtime API's are added here to prevent abort during register > access. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/usb/dwc3/dwc3-omap.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > index 34578de..6a0e17f 100644 > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc3-omap.c > @@ -43,6 +43,7 @@ > #include <linux/spinlock.h> > #include <linux/platform_device.h> > #include <linux/platform_data/dwc3-omap.h> > +#include <linux/pm_runtime.h> > #include <linux/dma-mapping.h> > #include <linux/ioport.h> > #include <linux/io.h> > @@ -281,6 +282,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev) > omap->irq = irq; > omap->base = base; > > + pm_runtime_enable(dev); > + ret = pm_runtime_get_sync(dev); > + if (ret < 0) { > + dev_err(dev, "get_sync failed with err %d\n", ret); > + goto err1; > + } > + > reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS); > > utmi_mode = of_get_property(node, "utmi-mode", &size); > @@ -354,6 +362,8 @@ err1: > static int __devexit dwc3_omap_remove(struct platform_device *pdev) > { > device_for_each_child(&pdev->dev, NULL, dwc3_remove_core); > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); You're going to disable pm_runtime here, so it's better to use pm_runtime_put_sync(), I guess ??
Hi, On Fri, Sep 28, 2012 at 6:28 PM, Felipe Balbi <balbi@ti.com> wrote: > Hi, > > On Fri, Sep 28, 2012 at 06:23:11PM +0530, Kishon Vijay Abraham I wrote: >> Before accessing any register, runtime API's should be invoked to enable >> the clocks. runtime API's are added here to prevent abort during register >> access. >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> drivers/usb/dwc3/dwc3-omap.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c >> index 34578de..6a0e17f 100644 >> --- a/drivers/usb/dwc3/dwc3-omap.c >> +++ b/drivers/usb/dwc3/dwc3-omap.c >> @@ -43,6 +43,7 @@ >> #include <linux/spinlock.h> >> #include <linux/platform_device.h> >> #include <linux/platform_data/dwc3-omap.h> >> +#include <linux/pm_runtime.h> >> #include <linux/dma-mapping.h> >> #include <linux/ioport.h> >> #include <linux/io.h> >> @@ -281,6 +282,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev) >> omap->irq = irq; >> omap->base = base; >> >> + pm_runtime_enable(dev); >> + ret = pm_runtime_get_sync(dev); >> + if (ret < 0) { >> + dev_err(dev, "get_sync failed with err %d\n", ret); >> + goto err1; >> + } >> + >> reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS); >> >> utmi_mode = of_get_property(node, "utmi-mode", &size); >> @@ -354,6 +362,8 @@ err1: >> static int __devexit dwc3_omap_remove(struct platform_device *pdev) >> { >> device_for_each_child(&pdev->dev, NULL, dwc3_remove_core); >> + pm_runtime_put(&pdev->dev); >> + pm_runtime_disable(&pdev->dev); > > You're going to disable pm_runtime here, so it's better to use > pm_runtime_put_sync(), I guess ?? sure. Will post a patch fixing it. Thanks Kishon
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 34578de..6a0e17f 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -43,6 +43,7 @@ #include <linux/spinlock.h> #include <linux/platform_device.h> #include <linux/platform_data/dwc3-omap.h> +#include <linux/pm_runtime.h> #include <linux/dma-mapping.h> #include <linux/ioport.h> #include <linux/io.h> @@ -281,6 +282,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev) omap->irq = irq; omap->base = base; + pm_runtime_enable(dev); + ret = pm_runtime_get_sync(dev); + if (ret < 0) { + dev_err(dev, "get_sync failed with err %d\n", ret); + goto err1; + } + reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS); utmi_mode = of_get_property(node, "utmi-mode", &size); @@ -354,6 +362,8 @@ err1: static int __devexit dwc3_omap_remove(struct platform_device *pdev) { device_for_each_child(&pdev->dev, NULL, dwc3_remove_core); + pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); return 0; }
Before accessing any register, runtime API's should be invoked to enable the clocks. runtime API's are added here to prevent abort during register access. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/usb/dwc3/dwc3-omap.c | 10 ++++++++++ 1 file changed, 10 insertions(+)