From patchwork Fri Sep 28 21:36:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1526471 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 2D6E3DF283 for ; Fri, 28 Sep 2012 21:40:52 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1THiGf-0002dF-Iz; Fri, 28 Sep 2012 21:38:41 +0000 Received: from moutng.kundenserver.de ([212.227.126.186]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1THiEc-0001mP-H7 for linux-arm-kernel@lists.infradead.org; Fri, 28 Sep 2012 21:36:35 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0M9N4I-1T9Uls0ol4-00CLCv; Fri, 28 Sep 2012 23:36:22 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/12] tty/console: fix warnings in drivers/tty/serial/kgdboc.c Date: Fri, 28 Sep 2012 23:36:14 +0200 Message-Id: <1348868177-21205-10-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1348868177-21205-1-git-send-email-arnd@arndb.de> References: <1348868177-21205-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:Cfqt7UvwbYX9gMqm2lDc8Sq7+SuSpUVWWJ8OdhxNULK cDBxPXAvoTu9bcTTz1bVuftmxDTKlsZBqAXeBS9S7E474wLssM m/8nmx4RLyaCEOtyzluQXlTROjAJ9jAqPsPMZuhA/JqrdFbb5g BllUCMOkHGfcEQ54jDe4TgZ2AIe+Bss2iM5gvVQx+IG7vewE4p T2SPfJFh8VMCjcXZ6i8DRxIJIoJmzobpfhaGfhQND/+qjiEuFD nVhmrcW6wHqY11nr7IX49gOYxasbSLUVfFzA9YUqJj/7WB5ERO bdwoSRzj53oPTW/qqZSjdR3DUqHhbVIC3h2oafUT0hSWYvKHon NIYuTL5+wfFh72Uf5RWFh4e91Jprgr9yf4G/79fcZFrSlcZnpE ZpseHSS/9uSyA== X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.186 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Anton Vorontsov , arm@kernel.org, Jason Wessel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The con_debug_leave/con_debug_enter functions are stubbed out by defining them to (0), which causes harmless build warnings. Using proper inline functions is the normal way to deal with this. Without this patch, building the ARM bcm2835_defconfig results in: drivers/tty/serial/kgdboc.c: In function 'kgdboc_pre_exp_handler': drivers/tty/serial/kgdboc.c:279:3: warning: statement with no effect [-Wunused-value] drivers/tty/serial/kgdboc.c: In function 'kgdboc_post_exp_handler': drivers/tty/serial/kgdboc.c:293:3: warning: statement with no effect [-Wunused-value] Signed-off-by: Arnd Bergmann Cc: Anton Vorontsov Cc: Jason Wessel Cc: Greg Kroah-Hartman Acked-by: Jason Wessel Acked-by: Greg Kroah-Hartman --- include/linux/console.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/linux/console.h b/include/linux/console.h index 7201ce4..dedb082 100644 --- a/include/linux/console.h +++ b/include/linux/console.h @@ -83,8 +83,14 @@ void give_up_console(const struct consw *sw); int con_debug_enter(struct vc_data *vc); int con_debug_leave(void); #else -#define con_debug_enter(vc) (0) -#define con_debug_leave() (0) +static inline int con_debug_enter(struct vc_data *vc) +{ + return 0; +} +static inline int con_debug_leave(void) +{ + return 0; +} #endif /* scroll */