From patchwork Fri Sep 28 21:36:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1526371 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 49799DF283 for ; Fri, 28 Sep 2012 21:38:47 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1THiF2-0001qW-Pb; Fri, 28 Sep 2012 21:37:00 +0000 Received: from moutng.kundenserver.de ([212.227.126.186]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1THiEX-0001lG-86 for linux-arm-kernel@lists.infradead.org; Fri, 28 Sep 2012 21:36:31 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0Lwnl2-1TXKJP0GNc-016njv; Fri, 28 Sep 2012 23:36:19 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/12] mtd: atmel nand: build regression Date: Fri, 28 Sep 2012 23:36:06 +0200 Message-Id: <1348868177-21205-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1348868177-21205-1-git-send-email-arnd@arndb.de> References: <1348868177-21205-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:9Fbq1MsUJ6ygBmdvuMvCw5l1YBa5tixauLBXHjpezPS 7XjGAC0y9mmto3CZ2xKlakgzP7Yd/X8mcfvmBCXrmGIej4hzbT 3RM0Wxjjhs8Ia4YbrdAfhMHI9XwZ4p3Qd/mYUZ+rrk7T/XBkda Yb12wN8gA94mIuJLduualKvZPs54CoGgh9y7Xrs7wx03Q0eNFT N+uqNje4f2y8HkKW9S6bnBQtjvmWHgtIrYM3USXJ63mUOXthhq wBCqrWPCmR2dloXXx0b6fB8Rc/FIEd5mwF7/9cJxiRtREv8jI0 e2EHFcZIlyTgYvIJMFlALr+UMJbH6bJ17wMyXJa4vJiuQXF9yx AOXBGcUEGCsSm70dfUzWbyn0RIDMLjOywUt+ZvUTZy+H6gI3Hh S3ODNglIchogw== X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.186 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Artem Bityutskiy , arm@kernel.org, Jean-Christophe PLAGNIOL-VILLARD , linux-kernel@vger.kernel.org, Arnd Bergmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The atmel_nand driver was broken by b654a9a46fc2 "mtd: atmel nand: fix gpio missing request". This is a rather helpless attempt to fix this, probably messing up the error handling even further but getting the build to work again, so please treat it as a bug report rather than a fix to be applied. Without this patch, building any at91 configuration results in: drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe': drivers/mtd/nand/atmel_nand.c:1451:4: error: label 'err_ecc_ioremap' used but not defined Signed-off-by: Arnd Bergmann Cc: Jean-Christophe PLAGNIOL-VILLARD Cc: Artem Bityutskiy --- drivers/mtd/nand/atmel_nand.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 9144557..eba5b2a 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1420,7 +1420,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev) dev_err(&pdev->dev, "can't request rdy gpio %d\n", host->board.rdy_pin); - goto err_ecc_ioremap; + goto err_no_card; } res = gpio_direction_input(host->board.rdy_pin); @@ -1428,7 +1428,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev) dev_err(&pdev->dev, "can't request input direction rdy gpio %d\n", host->board.rdy_pin); - goto err_ecc_ioremap; + goto err_no_card; } nand_chip->dev_ready = atmel_nand_device_ready; @@ -1440,7 +1440,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev) dev_err(&pdev->dev, "can't request enable gpio %d\n", host->board.enable_pin); - goto err_ecc_ioremap; + goto err_no_card; } res = gpio_direction_output(host->board.enable_pin, 1); @@ -1448,7 +1448,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev) dev_err(&pdev->dev, "can't request output direction enable gpio %d\n", host->board.enable_pin); - goto err_ecc_ioremap; + goto err_no_card; } }