| Message ID | 1348868177-21205-5-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Saturday, September 29, 2012 6:36 AM Arnd Bergmann wrote > > Something is wrong with the exynos_dp_core logic, and gcc > emits a warning about this. An array is declared in > exynos_dp_process_equalizer_training with length '2', > and exynos_dp_channel_eq_ok tries to access the third > element of it. > > This patch is certainly not correct, but hopefully helps > highlight the actual problem. The problem apparently was > introduced by d5c0eed01 "video: exynos_dp: adjust voltage > swing and pre-emphasis during Link Training". > > This is what we get in exynos_defconfig: > drivers/video/exynos/exynos_dp_core.c: In function 'exynos_dp_process_equalizer_training': > drivers/video/exynos/exynos_dp_core.c:341:13: warning: array subscript is above array bounds [-Warray- > bounds] Hi Arnd Bergmann, This problem was fixed. So, this patch is not necessary. As you mentioned, this problem was introduced by d5c0eed01 "video: exynos_dp: adjust voltage swing and pre-emphasis during Link Training". However, this problem was resolved by e75478b "video: exynos_dp: replace link_status with link_align to check channel equalization". The patch was merged to 'fbdev-next', and will be merged to '3.7-rc1', soon. Thank you. Best regards, Jingoo Han > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> > --- > drivers/video/exynos/exynos_dp_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c > index cdc1398..358b595 100644 > --- a/drivers/video/exynos/exynos_dp_core.c > +++ b/drivers/video/exynos/exynos_dp_core.c > @@ -542,7 +542,7 @@ reduce_link_rate: > > static int exynos_dp_process_equalizer_training(struct exynos_dp_device *dp) > { > - u8 link_status[2]; > + u8 link_status[3]; > u8 link_align[3]; > int lane; > int lane_count; > -- > 1.7.10
On Friday 05 October 2012, Jingoo Han wrote: > This problem was fixed. So, this patch is not necessary. > > As you mentioned, this problem was introduced by d5c0eed01 > "video: exynos_dp: adjust voltage swing and pre-emphasis > during Link Training". > > However, this problem was resolved by e75478b "video: exynos_dp: > replace link_status with link_align to check channel equalization". > > The patch was merged to 'fbdev-next', and will be merged to > '3.7-rc1', soon. Thank you. Ok, thanks for letting know. I'll drop my patch then. Arnd
diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c index cdc1398..358b595 100644 --- a/drivers/video/exynos/exynos_dp_core.c +++ b/drivers/video/exynos/exynos_dp_core.c @@ -542,7 +542,7 @@ reduce_link_rate: static int exynos_dp_process_equalizer_training(struct exynos_dp_device *dp) { - u8 link_status[2]; + u8 link_status[3]; u8 link_align[3]; int lane; int lane_count;
Something is wrong with the exynos_dp_core logic, and gcc emits a warning about this. An array is declared in exynos_dp_process_equalizer_training with length '2', and exynos_dp_channel_eq_ok tries to access the third element of it. This patch is certainly not correct, but hopefully helps highlight the actual problem. The problem apparently was introduced by d5c0eed01 "video: exynos_dp: adjust voltage swing and pre-emphasis during Link Training". This is what we get in exynos_defconfig: drivers/video/exynos/exynos_dp_core.c: In function 'exynos_dp_process_equalizer_training': drivers/video/exynos/exynos_dp_core.c:341:13: warning: array subscript is above array bounds [-Warray-bounds] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Jingoo Han <jg1.han@samsung.com> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> --- drivers/video/exynos/exynos_dp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)