From patchwork Fri Sep 28 21:36:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1526381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 1AB0C3FE80 for ; Fri, 28 Sep 2012 21:38:56 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1THiFF-0001ud-OM; Fri, 28 Sep 2012 21:37:13 +0000 Received: from moutng.kundenserver.de ([212.227.126.171]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1THiET-0001kT-Ti for linux-arm-kernel@lists.infradead.org; Fri, 28 Sep 2012 21:36:27 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0M1QSH-1Tbz8n0r85-00tpK6; Fri, 28 Sep 2012 23:36:20 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/12] video: exynos: warnings in exynos_dp_core.c Date: Fri, 28 Sep 2012 23:36:09 +0200 Message-Id: <1348868177-21205-5-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1348868177-21205-1-git-send-email-arnd@arndb.de> References: <1348868177-21205-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:MT4x+27R6KkRRROhu3FFpGKrgwf3rtalsumOCvB0XZs aswBExNttxnA1Hcr+oV1jNSbsAne8zhYIOO/om4ICbe+Iir8bS LrFgUVP9bbx3QcvVsth2UXgpmTorNT3LJicBgMHiOrgkhN5BnW oOBukqKPFZUT+2SsByjKVY4LbwxViewyuCQ3R8qetjrLScPz9I NFD0zmqxkImK8kwbrKjyd2S8T0sRm+hiwhGwi1Bo/isXeyryWJ 7IRL7dPVQUxKuyFEbD3JcZ9wVaETOX3WoaxhmvfQwWwMicHOkA WmlfAugDCSt+VAsSgzeLi9bzWEy7ASY+Lqa14nB8ELqNvPvvGd azM5L5S2uE70qvBkD3t4XUTeRd2uTfy5TARQuSy1KSZ5eVQ3qa 3otOPIVeNvXOg== X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.171 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Jingoo Han , arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Florian Tobias Schandinat X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Something is wrong with the exynos_dp_core logic, and gcc emits a warning about this. An array is declared in exynos_dp_process_equalizer_training with length '2', and exynos_dp_channel_eq_ok tries to access the third element of it. This patch is certainly not correct, but hopefully helps highlight the actual problem. The problem apparently was introduced by d5c0eed01 "video: exynos_dp: adjust voltage swing and pre-emphasis during Link Training". This is what we get in exynos_defconfig: drivers/video/exynos/exynos_dp_core.c: In function 'exynos_dp_process_equalizer_training': drivers/video/exynos/exynos_dp_core.c:341:13: warning: array subscript is above array bounds [-Warray-bounds] Signed-off-by: Arnd Bergmann Cc: Jingoo Han Cc: Florian Tobias Schandinat --- drivers/video/exynos/exynos_dp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c index cdc1398..358b595 100644 --- a/drivers/video/exynos/exynos_dp_core.c +++ b/drivers/video/exynos/exynos_dp_core.c @@ -542,7 +542,7 @@ reduce_link_rate: static int exynos_dp_process_equalizer_training(struct exynos_dp_device *dp) { - u8 link_status[2]; + u8 link_status[3]; u8 link_align[3]; int lane; int lane_count;