From patchwork Thu Oct 4 01:16:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 1544231 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 89492DFF71 for ; Thu, 4 Oct 2012 01:19:12 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TJa4G-0003i7-EA; Thu, 04 Oct 2012 01:17:36 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TJa3W-0003ai-Ql for linux-arm-kernel@lists.infradead.org; Thu, 04 Oct 2012 01:16:52 +0000 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q941Gmig028092; Wed, 3 Oct 2012 20:16:48 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q941Gm0B015828; Wed, 3 Oct 2012 20:16:48 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by dfle73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.1.323.3; Wed, 3 Oct 2012 20:16:48 -0500 Received: from nucleus.nsc.com (nucleus.nsc.com [10.188.36.112]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id q941Gir6013802; Wed, 3 Oct 2012 20:16:47 -0500 From: Mike Turquette To: , Subject: [PATCH 5/5] ARM: omap: initialize voltdm->nominal_volt Date: Wed, 3 Oct 2012 18:16:05 -0700 Message-ID: <1349313365-5262-6-git-send-email-mturquette@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349313365-5262-1-git-send-email-mturquette@ti.com> References: <1349313365-5262-1-git-send-email-mturquette@ti.com> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -9.0 (---------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-9.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -2.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, Mike Turquette , linux-arm-kernel@lists.infradead.org, Mike Turquette X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Mike Turquette Populate the .get_voltage callbacks for VC & VP. Use these callbacks to populate voltdm->nominal_volt during boot sequence. This is useful for the Adaptive Body-Bias sequence coming in a subsequent series. Without this patch voltdm->nominal will not be populated until after the first call to voltdm_scale. This is too late to be useful to the pre-scale sequence in the ABB series since that sequence needs to know the voltage prior to the first transition. Note that the .get_voltage callback will return zero for the corner case wherein the bootloader has not scaling the voltage. In this case it is safe to assume that we are running at the PMIC's default power-on voltage. DT data providing the default voltage for each PMIC is needed in this case. Signed-off-by: Mike Turquette Signed-off-by: Mike Turquette --- arch/arm/mach-omap2/voltage.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c index 4dc60e8..f45716c 100644 --- a/arch/arm/mach-omap2/voltage.c +++ b/arch/arm/mach-omap2/voltage.c @@ -244,9 +244,11 @@ void omap_change_voltscale_method(struct voltagedomain *voltdm, switch (voltscale_method) { case VOLTSCALE_VPFORCEUPDATE: voltdm->scale = omap_vp_forceupdate_scale; + voltdm->get_voltage = omap_vp_get_init_voltage; return; case VOLTSCALE_VCBYPASS: voltdm->scale = omap_vc_bypass_scale; + voltdm->get_voltage = omap_vc_get_bypass_data; return; default: pr_warning("%s: Trying to change the method of voltage scaling" @@ -288,13 +290,24 @@ int __init omap_voltage_late_init(void) if (voltdm->vc) { voltdm->scale = omap_vc_bypass_scale; + voltdm->get_voltage = omap_vc_get_bypass_data; omap_vc_init_channel(voltdm); } if (voltdm->vp) { voltdm->scale = omap_vp_forceupdate_scale; + voltdm->get_voltage = omap_vp_get_init_voltage; omap_vp_init(voltdm); } + + /* + * XXX If voltdm->nominal_volt is zero after calling + * voltdm->get_voltage then we are likely running this + * voltage domain at the default boot voltage of the + * PMIC. In such a case it would be best to load this + * value from DT. + */ + voltdm->nominal_volt = voltdm->get_voltage(voltdm); } return 0;