From patchwork Thu Oct 4 15:42:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 1545101 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id A1AFFDF6DA for ; Thu, 4 Oct 2012 07:27:10 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TJfoD-0003Dj-35; Thu, 04 Oct 2012 07:25:25 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TJfnY-00035B-NY for linux-arm-kernel@lists.infradead.org; Thu, 04 Oct 2012 07:24:45 +0000 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MBC00LFOXWSZVQ0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 04 Oct 2012 16:24:40 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 2F.95.03783.7B93D605; Thu, 04 Oct 2012 16:24:39 +0900 (KST) X-AuditID: cbfee61a-b7f726d000000ec7-74-506d39b76e3d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9E.95.03783.7B93D605; Thu, 04 Oct 2012 16:24:39 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MBC006I9XWMLU10@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 04 Oct 2012 16:24:39 +0900 (KST) From: Rahul Sharma To: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: [PATCH v1 03/14] drm: exynos: hdmi: fix interrupt handling Date: Thu, 04 Oct 2012 21:12:41 +0530 Message-id: <1349365372-21417-4-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1349365372-21417-1-git-send-email-rahul.sharma@samsung.com> References: <1349365372-21417-1-git-send-email-rahul.sharma@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWyRsSkTne7ZW6AwdXdBhabHl9jdWD02Lyk PoAxissmJTUnsyy1SN8ugStj3ed1jAVvOCr+P2xjbWBcx97FyMkhIWAicWjaSlYIW0ziwr31 bF2MXBxCAksZJXYt3MsIU9R0ZQ8TRGI6o8TCiw2sEM4GJokbrY/BRrEJ6ErMPvgMrENEwFVi 65abYDazQJLE95+TmEBsYQFniTv3W1lAbBYBVYmLnxuA4hwcvAIeEt8nSEIsU5BoXXaIHSTM KeApceRnIkhYCKhi0ocOVohOAYlvkw+xgJRICMhKbDrADNF5mU3iwF8oW1Li4IobLBMYhRcw MqxiFE0tSC4oTkrPNdQrTswtLs1L10vOz93ECAy/0/+eSe1gXNlgcYhRgINRiYfXsDsnQIg1 say4MvcQowQHs5II72bF3AAh3pTEyqrUovz4otKc1OJDjD5Ah0xklhJNzgfGRl5JvKGxibmp samlkZGZqSkOYSVx3maPlAAhgfTEktTs1NSC1CKYcUwcnFINjCl8nhtSUu4/lJR+pXKyNFFl f6i/Yq/xv83a39rcMrY8efdN+avRoQkLbk24vYBjYdTX62Gdrw96Bl8IWdK0dH355CsRwvEr v/gGZdczBp5UXrK9oNiKNe+iQ9JpxadrdxWG/50Ra9/Qb3ps+ovzt/J3Mh7Ni+TWcFt88u/2 n1OPfqsU/6Hwb6cSS3FGoqEWc1FxIgCVhE0obAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e+xoO52y9wAg/PPlC02Pb7G6sDosXlJ fQBjVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7Q VCWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYQ1jxrrP6xgL3nBU/H/YxtrA uI69i5GTQ0LARKLpyh4mCFtM4sK99WxdjFwcQgLTGSUWXmxghXA2MEncaH0M1sEmoCsx++Az RhBbRMBVYuuWm2A2s0CSxPefk8AmCQs4S9y538oCYrMIqEpc/NwAFOfg4BXwkPg+QRJimYJE 67JD7CBhTgFPiSM/E0HCQkAVkz50sE5g5F3AyLCKUTS1ILmgOCk911CvODG3uDQvXS85P3cT Izi8n0ntYFzZYHGIUYCDUYmH17A7J0CINbGsuDL3EKMEB7OSCO9mxdwAId6UxMqq1KL8+KLS nNTiQ4w+QDdNZJYSTc4Hxl5eSbyhsYm5qbGppYmFiZklDmElcd5mj5QAIYH0xJLU7NTUgtQi mHFMHJxSDYyWKVm7FW5Ka75M46jgFzT7eor7o0OB4d2X611XSmbwLLW4//LaimW2PxfsuxMV omQ2/bJp8pmtHh8UF4vdXsz+T/mDweYyJe748xGzrn3wt1LaOs3foVdyjqGw5I4JZcnpE2Ze OcM6S/L5tmcznpeGfVHUYGL33bBMp0re6VTYv9AfYgvi9joqsRRnJBpqMRcVJwIAYH0rVpwC AAA= X-CFilter-Loop: Reflected X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.9 DATE_IN_FUTURE_06_12 Date: is 6 to 12 hours after Received: date -2.1 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: t.stanislaws@samsung.com, inki.dae@samsung.com, kyungmin.park@samsung.com, joshi@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tomasz Stanislawski This patch fixes 'unsigned < 0' check in probe. Moreover it releases an interrupt at remove. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index b3a802b..3902917 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -64,8 +64,8 @@ struct hdmi_context { struct mutex hdmi_mutex; void __iomem *regs; - unsigned int external_irq; - unsigned int internal_irq; + int external_irq; + int internal_irq; struct i2c_client *ddc_port; struct i2c_client *hdmiphy_port; @@ -2424,6 +2424,7 @@ static int __devexit hdmi_remove(struct platform_device *pdev) pm_runtime_disable(dev); free_irq(hdata->internal_irq, hdata); + free_irq(hdata->external_irq, hdata); hdmi_resources_cleanup(hdata);