From patchwork Fri Oct 5 10:16:08 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 1552411 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id DCEBC3FCFC for ; Fri, 5 Oct 2012 10:18:53 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TK4xU-0000jD-D3; Fri, 05 Oct 2012 10:16:40 +0000 Received: from mail-ee0-f49.google.com ([74.125.83.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TK4x9-0000gt-QT for linux-arm-kernel@lists.infradead.org; Fri, 05 Oct 2012 10:16:21 +0000 Received: by mail-ee0-f49.google.com with SMTP id c1so1139292eek.36 for ; Fri, 05 Oct 2012 03:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=GnGwD9+18JP6rKFffAk2Rh/2tcwKE64f0tR0hqY4M0E=; b=vYD6f95np2+QJ9euh6h4wlkAC7FPDv8jrqT3VWSbyRulsBkev+PIpNIz+5NCRKLC0s L4RXhLubR6kvwz/ZqGtEpia+cEv9TpR3f8gcz+B60wJ8vscXGVV4yUWlM/dat/n0NOvk HbOkzhFtl5lSVhHfs05QP0Go4KgsoJDRyWtmbtdtUUxY9tpFdJ7zOSnlQW2u59N7ENSt HAsUVCiROXZfMN+njnXNguvbxT24ArrF7sX41QVvnrkQUcaTg5rVbIp2YYCtQh3reWY3 aQL8oUI1GcpAAPJoM2kmmqBBUe/sPwq/sz1g96cxonf3rLcA9HbDL9y5jcV/ZQjCEBV7 6jiA== Received: by 10.14.219.198 with SMTP id m46mr12137133eep.18.1349432178388; Fri, 05 Oct 2012 03:16:18 -0700 (PDT) Received: from ld2036.tmt.telital.com ([213.205.6.118]) by mx.google.com with ESMTPS id 7sm1559321eeg.5.2012.10.05.03.16.16 (version=SSLv3 cipher=OTHER); Fri, 05 Oct 2012 03:16:17 -0700 (PDT) From: Fabio Porcedda To: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Ferre , Jean-Christophe PLAGNIOL-VILLARD , Andrew Victor , Jason Cooper , Andrew Lunn Subject: [RFC PATCH v3 3/4] watchdog: orion_wdt: litte cleanup Date: Fri, 5 Oct 2012 12:16:08 +0200 Message-Id: <1349432169-13006-4-git-send-email-fabio.porcedda@gmail.com> X-Mailer: git-send-email 1.7.11.3 In-Reply-To: <1349432169-13006-1-git-send-email-fabio.porcedda@gmail.com> References: <1349432169-13006-1-git-send-email-fabio.porcedda@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.83.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (fabio.porcedda[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: devicetree-discuss@lists.ozlabs.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org - Move the min_timeout initialization inside the orion_wdt definition. - Change orion_wdt_of_match_table from __devinitdata to __devinitconst. Signed-off-by: Fabio Porcedda --- drivers/watchdog/orion_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt.c index 3417f1b..9e09598 100644 --- a/drivers/watchdog/orion_wdt.c +++ b/drivers/watchdog/orion_wdt.c @@ -139,6 +139,7 @@ static const struct watchdog_ops orion_wdt_ops = { static struct watchdog_device orion_wdt = { .info = &orion_wdt_info, .ops = &orion_wdt_ops, + .min_timeout = 1, }; static int __devinit orion_wdt_probe(struct platform_device *pdev) @@ -161,7 +162,6 @@ static int __devinit orion_wdt_probe(struct platform_device *pdev) wdt_max_duration = WDT_MAX_CYCLE_COUNT / wdt_tclk; - orion_wdt.min_timeout = 1; orion_wdt.max_timeout = wdt_max_duration; orion_wdt.timeout = wdt_max_duration; watchdog_init_timeout(&orion_wdt, heartbeat, pdev->dev.of_node); @@ -190,7 +190,7 @@ static void orion_wdt_shutdown(struct platform_device *pdev) orion_wdt_stop(&orion_wdt); } -static const struct of_device_id orion_wdt_of_match_table[] __devinitdata = { +static const struct of_device_id orion_wdt_of_match_table[] __devinitconst = { { .compatible = "marvell,orion-wdt", }, {}, };