From patchwork Fri Oct 5 14:55:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1553691 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id A4962DF24C for ; Fri, 5 Oct 2012 15:01:11 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TK9Lo-0004Ts-KV; Fri, 05 Oct 2012 14:58:04 +0000 Received: from moutng.kundenserver.de ([212.227.17.9]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TK9Jp-0003aI-Ag for linux-arm-kernel@lists.infradead.org; Fri, 05 Oct 2012 14:56:09 +0000 Received: from klappe2.boeblingen.de.ibm.com (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0Lvupd-1TU4Pk0GmT-017ofB; Fri, 05 Oct 2012 16:55:45 +0200 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/16] ARM: warnings in arch/arm/include/asm/uaccess.h Date: Fri, 5 Oct 2012 16:55:15 +0200 Message-Id: <1349448930-23976-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1349448930-23976-1-git-send-email-arnd@arndb.de> References: <1349448930-23976-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:xgkwAi3VsWjkrY6vAMpyEM/iPJLqKEnxkhRRMvqoE4s NPBTd36ONPjlG5lLcL/SACiC35fjBoBZLkmKwqYo3pfxUXH9XU AUtFMJDEprR45BPNAzyaK2BpgEVjknMF+C2fq6+xNytCh6xE6A TK44TZPOarF1rLRSsBhvbdx3Z1xZHnOPSKLSPeljI2V+WcVWMV Wncm7Z9LHtdn4rqTLuCX9yvs2h8DzvBTVyCWxArVyouJWx8Q+o vqAXoQl84idUsMBltDnrGDZDB9sTF2kr1L624WGJ0vUPgC4qJz P7ZAvwzQ8EdMEknIsRqh48SJbnRtPCJdGd19tcW9ReYrmlsJVc q9UA7KCxa4iduqIm/uixDYkDKV8pdVUpo5f3Ii9gcvKgVWkmJ4 25Z9v1F2c0dZxhiFWIxHJvYCzdE+VOxdTg= X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.9 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Russell King , arm@kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Ungerer X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On NOMMU ARM, the __addr_ok() and __range_ok() macros do not evaluate their arguments, which may lead to harmless build warnings in some code where the variables are not used otherwise. Adding a cast to void gets rid of the warning and does not make any semantic changes. Without this patch, building at91x40_defconfig results in: fs/read_write.c: In function 'rw_copy_check_uvector': fs/read_write.c:684:9: warning: unused variable 'buf' [-Wunused-variable] Signed-off-by: Arnd Bergmann Cc: Greg Ungerer Cc: Russell King Acked-by: Greg Ungerer --- arch/arm/include/asm/uaccess.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index 77bd79f..7e1f760 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -200,8 +200,8 @@ extern int __put_user_8(void *, unsigned long long); #define USER_DS KERNEL_DS #define segment_eq(a,b) (1) -#define __addr_ok(addr) (1) -#define __range_ok(addr,size) (0) +#define __addr_ok(addr) ((void)(addr),1) +#define __range_ok(addr,size) ((void)(addr),0) #define get_fs() (KERNEL_DS) static inline void set_fs(mm_segment_t fs)