From patchwork Sun Oct 7 08:00:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 1560821 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id A091A3FC1A for ; Sun, 7 Oct 2012 08:03:15 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TKln8-00016m-Tt; Sun, 07 Oct 2012 08:00:51 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TKln5-00016Y-AK for linux-arm-kernel@lists.infradead.org; Sun, 07 Oct 2012 08:00:47 +0000 Received: by mail-pb0-f49.google.com with SMTP id xa7so3424658pbc.36 for ; Sun, 07 Oct 2012 01:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:subject:from:to:cc:date:content-type:x-mailer :content-transfer-encoding:mime-version:x-gm-message-state; bh=fx0DlyVw34kNohUENSppw7UBGnEtkViIRmd7NOthn5g=; b=fUAEMM4h+43YnxoZjSjSQVUZy1uVMdPQuflK5nUdnhn8Oja2XcsuC+RUlMyNsJQkiW C/yFC5INb9di8GakgRBJi3rHfGMq4BFpfMmqpFSBUzMIaoi3xO/vbNe2hCbgUvxu8jcM lxDazR28dLsifXI6wLQXTjoWCU1YX8y/77ZdvpGzvbju6NlZ+pkPB9IjsSzhe6N6qVgr VclV8fYyYVr2+ZkdeXhm6up1mdwP5bUL5ZoWOR5GVI1A9DMlt5tdISsmerAr0Fl18nBI 4latSRc9u/3OlPaWZOEOALvxb3u5WLQ6kuLGAa2FGJjpZqeQIu/zoEQTC3Y23u9egRSW gwzw== Received: by 10.68.189.70 with SMTP id gg6mr44217599pbc.125.1349596842505; Sun, 07 Oct 2012 01:00:42 -0700 (PDT) Received: from [111.255.127.190] (111-255-127-190.dynamic.hinet.net. [111.255.127.190]) by mx.google.com with ESMTPS id sj5sm8806385pbc.30.2012.10.07.01.00.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 07 Oct 2012 01:00:42 -0700 (PDT) Message-ID: <1349596837.15349.2.camel@phoenix> Subject: [PATCH] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS From: Axel Lin To: Bryan Wu , Tony Lindgren Date: Sun, 07 Oct 2012 16:00:37 +0800 X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Gm-Message-State: ALoCoQn9n5OqWC886ewjihd+0gH0UI43wcL34k//vmnSuorGBZGc7Nogf/6ssjUbXBke3yz7mWCf X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.160.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This fixes below build error: LD init/built-in.o arch/arm/plat-omap/built-in.o: In function `fpga_probe': arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register' arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow make: *** [vmlinux] Error 1 Signed-off-by: Axel Lin --- Hi Bryan, I think this issue is introduced by commit dafbead "ARM: mach-omap1: retire custom LED code". Regards, Axel arch/arm/plat-omap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index ca83a76..3281377 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -42,7 +42,7 @@ config OMAP_DEBUG_DEVICES For debug cards on TI reference boards. config OMAP_DEBUG_LEDS - def_bool y if NEW_LEDS + default y if LEDS_CLASS depends on OMAP_DEBUG_DEVICES config POWER_AVS_OMAP