| Message ID | 1349870716-25511-2-git-send-email-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Lokesh, On 10/10/2012 02:05 PM, Lokesh Vutla wrote: > Renaming elpida_ecb240abacn.dtsi file generic, so that the > same file can be reused for other parts from different vendors. Could you elaborate a little bit? Are these settings purely reflecting lpddr2 spec timings? Regards, Benoit > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} | 0 > arch/arm/boot/dts/omap4-panda.dts | 2 +- > arch/arm/boot/dts/omap4-sdp.dts | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > rename arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} (100%) > > diff --git a/arch/arm/boot/dts/elpida_ecb240abacn.dtsi b/arch/arm/boot/dts/lpddr2_data.dtsi > similarity index 100% > rename from arch/arm/boot/dts/elpida_ecb240abacn.dtsi > rename to arch/arm/boot/dts/lpddr2_data.dtsi > diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts > index 20b966e..09d3a32 100644 > --- a/arch/arm/boot/dts/omap4-panda.dts > +++ b/arch/arm/boot/dts/omap4-panda.dts > @@ -8,7 +8,7 @@ > /dts-v1/; > > /include/ "omap4.dtsi" > -/include/ "elpida_ecb240abacn.dtsi" > +/include/ "lpddr2_data.dtsi" > > / { > model = "TI OMAP4 PandaBoard"; > diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts > index 94a23b3..dd749fc 100644 > --- a/arch/arm/boot/dts/omap4-sdp.dts > +++ b/arch/arm/boot/dts/omap4-sdp.dts > @@ -8,7 +8,7 @@ > /dts-v1/; > > /include/ "omap4.dtsi" > -/include/ "elpida_ecb240abacn.dtsi" > +/include/ "lpddr2_data.dtsi" > > / { > model = "TI OMAP4 SDP board"; >
+ devicetree-discuss Hi Benoit, On Wednesday 10 October 2012 08:18 PM, Benoit Cousson wrote: > Hi Lokesh, > > On 10/10/2012 02:05 PM, Lokesh Vutla wrote: >> Renaming elpida_ecb240abacn.dtsi file generic, so that the >> same file can be reused for other parts from different vendors. > > Could you elaborate a little bit? > Are these settings purely reflecting lpddr2 spec timings? The basic idea is to group data for all the lpddr2 devices in a single file instead of creating separate file for each lpddr2 device. Right now the file elpida_ecb240abacn.dtsi contains only data for lpddr2-s4 2G parts from Elpida. I wanted to add data for lpddr2-s4 4G parts from Samsung. So I renamed the file elpida_ecb240abacn.dtsi as lpddr2_data.dtsi. Please let me know if more clarification is needed. Thanks, Lokesh > > Regards, > Benoit > > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} | 0 >> arch/arm/boot/dts/omap4-panda.dts | 2 +- >> arch/arm/boot/dts/omap4-sdp.dts | 2 +- >> 3 files changed, 2 insertions(+), 2 deletions(-) >> rename arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} (100%) >> >> diff --git a/arch/arm/boot/dts/elpida_ecb240abacn.dtsi b/arch/arm/boot/dts/lpddr2_data.dtsi >> similarity index 100% >> rename from arch/arm/boot/dts/elpida_ecb240abacn.dtsi >> rename to arch/arm/boot/dts/lpddr2_data.dtsi >> diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts >> index 20b966e..09d3a32 100644 >> --- a/arch/arm/boot/dts/omap4-panda.dts >> +++ b/arch/arm/boot/dts/omap4-panda.dts >> @@ -8,7 +8,7 @@ >> /dts-v1/; >> >> /include/ "omap4.dtsi" >> -/include/ "elpida_ecb240abacn.dtsi" >> +/include/ "lpddr2_data.dtsi" >> >> / { >> model = "TI OMAP4 PandaBoard"; >> diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts >> index 94a23b3..dd749fc 100644 >> --- a/arch/arm/boot/dts/omap4-sdp.dts >> +++ b/arch/arm/boot/dts/omap4-sdp.dts >> @@ -8,7 +8,7 @@ >> /dts-v1/; >> >> /include/ "omap4.dtsi" >> -/include/ "elpida_ecb240abacn.dtsi" >> +/include/ "lpddr2_data.dtsi" >> >> / { >> model = "TI OMAP4 SDP board"; >> >
On 10/11/2012 08:16 AM, Lokesh Vutla wrote: > + devicetree-discuss > > Hi Benoit, > > On Wednesday 10 October 2012 08:18 PM, Benoit Cousson wrote: >> Hi Lokesh, >> >> On 10/10/2012 02:05 PM, Lokesh Vutla wrote: >>> Renaming elpida_ecb240abacn.dtsi file generic, so that the >>> same file can be reused for other parts from different vendors. >> >> Could you elaborate a little bit? >> Are these settings purely reflecting lpddr2 spec timings? > > The basic idea is to group data for all the lpddr2 devices in a single > file instead of creating separate file for each lpddr2 device. > > Right now the file elpida_ecb240abacn.dtsi contains only data for > lpddr2-s4 2G parts from Elpida. > I wanted to add data for lpddr2-s4 4G parts from Samsung. > So I renamed the file elpida_ecb240abacn.dtsi as lpddr2_data.dtsi. > > Please let me know if more clarification is needed. Well, not anymore... as explained in the previous email, you should not do that. Keep the Elpida file and create another one for the Samsung part. Then each board will be able to select the proper one and include only the relevant data. Regards, Benoit
On Thursday 11 October 2012 01:58 PM, Benoit Cousson wrote: > On 10/11/2012 08:16 AM, Lokesh Vutla wrote: >> + devicetree-discuss >> >> Hi Benoit, >> >> On Wednesday 10 October 2012 08:18 PM, Benoit Cousson wrote: >>> Hi Lokesh, >>> >>> On 10/10/2012 02:05 PM, Lokesh Vutla wrote: >>>> Renaming elpida_ecb240abacn.dtsi file generic, so that the >>>> same file can be reused for other parts from different vendors. >>> >>> Could you elaborate a little bit? >>> Are these settings purely reflecting lpddr2 spec timings? >> >> The basic idea is to group data for all the lpddr2 devices in a single >> file instead of creating separate file for each lpddr2 device. >> >> Right now the file elpida_ecb240abacn.dtsi contains only data for >> lpddr2-s4 2G parts from Elpida. >> I wanted to add data for lpddr2-s4 4G parts from Samsung. >> So I renamed the file elpida_ecb240abacn.dtsi as lpddr2_data.dtsi. >> >> Please let me know if more clarification is needed. > > Well, not anymore... as explained in the previous email, you should not > do that. > Keep the Elpida file and create another one for the Samsung part. > Then each board will be able to select the proper one and include only > the relevant data. OK, Ill agree with you. I ll do the changes and post the V2. Thanks, Lokesh > > Regards, > Benoit >
diff --git a/arch/arm/boot/dts/elpida_ecb240abacn.dtsi b/arch/arm/boot/dts/lpddr2_data.dtsi similarity index 100% rename from arch/arm/boot/dts/elpida_ecb240abacn.dtsi rename to arch/arm/boot/dts/lpddr2_data.dtsi diff --git a/arch/arm/boot/dts/omap4-panda.dts b/arch/arm/boot/dts/omap4-panda.dts index 20b966e..09d3a32 100644 --- a/arch/arm/boot/dts/omap4-panda.dts +++ b/arch/arm/boot/dts/omap4-panda.dts @@ -8,7 +8,7 @@ /dts-v1/; /include/ "omap4.dtsi" -/include/ "elpida_ecb240abacn.dtsi" +/include/ "lpddr2_data.dtsi" / { model = "TI OMAP4 PandaBoard"; diff --git a/arch/arm/boot/dts/omap4-sdp.dts b/arch/arm/boot/dts/omap4-sdp.dts index 94a23b3..dd749fc 100644 --- a/arch/arm/boot/dts/omap4-sdp.dts +++ b/arch/arm/boot/dts/omap4-sdp.dts @@ -8,7 +8,7 @@ /dts-v1/; /include/ "omap4.dtsi" -/include/ "elpida_ecb240abacn.dtsi" +/include/ "lpddr2_data.dtsi" / { model = "TI OMAP4 SDP board";
Renaming elpida_ecb240abacn.dtsi file generic, so that the same file can be reused for other parts from different vendors. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} | 0 arch/arm/boot/dts/omap4-panda.dts | 2 +- arch/arm/boot/dts/omap4-sdp.dts | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename arch/arm/boot/dts/{elpida_ecb240abacn.dtsi => lpddr2_data.dtsi} (100%)