diff mbox

[4/6] ARM: ux500: Add UART support to the u9540 Device Tree

Message ID 1349882335-6786-5-git-send-email-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Lee Jones Oct. 10, 2012, 3:18 p.m. UTC
Add the 3 UART nodes required to enable serial ports on the u9540.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Jean-Christophe PLAGNIOL-VILLARD Oct. 10, 2012, 7:03 p.m. UTC | #1
On 16:18 Wed 10 Oct     , Lee Jones wrote:
> Add the 3 UART nodes required to enable serial ports on the u9540.
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
dts? it's dtsi

it's the soc not the board
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts
> index 0a66f34..28efe20 100644
> --- a/arch/arm/boot/dts/u9540.dts
> +++ b/arch/arm/boot/dts/u9540.dts
> @@ -21,6 +21,17 @@
>  	};
>  
>  	soc-u9500 {
> -	};
>  
> +		uart@80120000 {
> +			status = "okay";
> +		};
> +
> +		uart@80121000 {
> +			status = "okay";
> +		};
> +
> +		uart@80007000 {
> +			status = "okay";
> +		};
do not enable device by default in the soc

Best Regards,
J.
> +	};
>  };
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Lee Jones Oct. 11, 2012, 7:29 a.m. UTC | #2
On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 16:18 Wed 10 Oct     , Lee Jones wrote:
> > Add the 3 UART nodes required to enable serial ports on the u9540.
> > 
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
> dts? it's dtsi

No it's not.

> it's the soc not the board

This is the board file, not the SoC.

> >  1 file changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts
> > index 0a66f34..28efe20 100644
> > --- a/arch/arm/boot/dts/u9540.dts
> > +++ b/arch/arm/boot/dts/u9540.dts
> > @@ -21,6 +21,17 @@
> >  	};
> >  
> >  	soc-u9500 {
> > -	};
> >  
> > +		uart@80120000 {
> > +			status = "okay";
> > +		};
> > +
> > +		uart@80121000 {
> > +			status = "okay";
> > +		};
> > +
> > +		uart@80007000 {
> > +			status = "okay";
> > +		};
> do not enable device by default in the soc

See above.
Jean-Christophe PLAGNIOL-VILLARD Oct. 11, 2012, 8:50 a.m. UTC | #3
On 08:29 Thu 11 Oct     , Lee Jones wrote:
> On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On 16:18 Wed 10 Oct     , Lee Jones wrote:
> > > Add the 3 UART nodes required to enable serial ports on the u9540.
> > > 
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
> > dts? it's dtsi
> 
> No it's not.
so the name of the file is wrong s u9540 is a SoC name

Best Regards,
J.
Lee Jones Oct. 11, 2012, 9:22 a.m. UTC | #4
On Thu, 11 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 08:29 Thu 11 Oct     , Lee Jones wrote:
> > On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > 
> > > On 16:18 Wed 10 Oct     , Lee Jones wrote:
> > > > Add the 3 UART nodes required to enable serial ports on the u9540.
> > > > 
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > > ---
> > > >  arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
> > > dts? it's dtsi
> > 
> > No it's not.
> so the name of the file is wrong s u9540 is a SoC name

The board could actually be called either ccu9540, or just 
u9540. I picked one and went with it. The full name is the
u9540 development board.
Jean-Christophe PLAGNIOL-VILLARD Oct. 11, 2012, 6:06 p.m. UTC | #5
On 10:22 Thu 11 Oct     , Lee Jones wrote:
> On Thu, 11 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On 08:29 Thu 11 Oct     , Lee Jones wrote:
> > > On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > 
> > > > On 16:18 Wed 10 Oct     , Lee Jones wrote:
> > > > > Add the 3 UART nodes required to enable serial ports on the u9540.
> > > > > 
> > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > > > ---
> > > > >  arch/arm/boot/dts/u9540.dts |   13 ++++++++++++-
> > > > dts? it's dtsi
> > > 
> > > No it's not.
> > so the name of the file is wrong s u9540 is a SoC name
> 
> The board could actually be called either ccu9540, or just 
> u9540. I picked one and went with it. The full name is the
> u9540 development board.
so use ccu9540 as u9540 is the soc name so if we use u9540 as compatible we
expect to mach the soc and not a board

Best Regards,
J.
Linus Walleij Oct. 12, 2012, 9:15 p.m. UTC | #6
On Thu, Oct 11, 2012 at 8:06 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 10:22 Thu 11 Oct     , Lee Jones wrote:

>> The board could actually be called either ccu9540, or just
>> u9540. I picked one and went with it. The full name is the
>> u9540 development board.
>
> so use ccu9540 as u9540 is the soc name so if we use u9540 as compatible we
> expect to mach the soc and not a board

I basically agree.

However the SoC (digital ASIC) is named DB9540.

U9540 is the entire chipset (DB9540, AB9540 etc) a variant
of the NovaThor series.

Yours,
Linus Walleij
diff mbox

Patch

diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts
index 0a66f34..28efe20 100644
--- a/arch/arm/boot/dts/u9540.dts
+++ b/arch/arm/boot/dts/u9540.dts
@@ -21,6 +21,17 @@ 
 	};
 
 	soc-u9500 {
-	};
 
+		uart@80120000 {
+			status = "okay";
+		};
+
+		uart@80121000 {
+			status = "okay";
+		};
+
+		uart@80007000 {
+			status = "okay";
+		};
+	};
 };