| Message ID | 1349882335-6786-6-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16:18 Wed 10 Oct , Lee Jones wrote: > Here we add the device node for the SDI4 (MMC) port to the u9540 > Device Tree source file. This will allow successful probing of > the internal MMC storage device when booting with DT enabled. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/u9540.dts | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts > index 28efe20..2dade76 100644 > --- a/arch/arm/boot/dts/u9540.dts > +++ b/arch/arm/boot/dts/u9540.dts > @@ -21,7 +21,6 @@ > }; > > soc-u9500 { > - why? > uart@80120000 { > status = "okay"; > }; > @@ -33,5 +32,16 @@ > uart@80007000 { > status = "okay"; > }; > + > + // On-board eMMC no c++ comment > + sdi4_per2@80114000 { > + arm,primecell-periphid = <0x10480180>; > + max-frequency = <50000000>; > + bus-width = <8>; > + mmc-cap-mmc-highspeed; > + vmmc-supply = <&ab8500_ldo_aux2_reg>; you need add the pinctrl here Best Regards, J.
On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 16:18 Wed 10 Oct , Lee Jones wrote: > > Here we add the device node for the SDI4 (MMC) port to the u9540 > > Device Tree source file. This will allow successful probing of > > the internal MMC storage device when booting with DT enabled. > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/arm/boot/dts/u9540.dts | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts > > index 28efe20..2dade76 100644 > > --- a/arch/arm/boot/dts/u9540.dts > > +++ b/arch/arm/boot/dts/u9540.dts > > @@ -21,7 +21,6 @@ > > }; > > > > soc-u9500 { > > - > why? My OCD shining though. It's either this or I create a seperate patch for it. I think sneaking it in here is better. > > uart@80120000 { > > status = "okay"; > > }; > > @@ -33,5 +32,16 @@ > > uart@80007000 { > > status = "okay"; > > }; > > + > > + // On-board eMMC > no c++ comment Single line comments are perfectly valid in DTS(I) files. See: Documentation/devicetree/booting-without-of.txt > > + sdi4_per2@80114000 { > > + arm,primecell-periphid = <0x10480180>; > > + max-frequency = <50000000>; > > + bus-width = <8>; > > + mmc-cap-mmc-highspeed; > > + vmmc-supply = <&ab8500_ldo_aux2_reg>; > you need add the pinctrl here Pinctrl will come in time. We have a priority list.
diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts index 28efe20..2dade76 100644 --- a/arch/arm/boot/dts/u9540.dts +++ b/arch/arm/boot/dts/u9540.dts @@ -21,7 +21,6 @@ }; soc-u9500 { - uart@80120000 { status = "okay"; }; @@ -33,5 +32,16 @@ uart@80007000 { status = "okay"; }; + + // On-board eMMC + sdi4_per2@80114000 { + arm,primecell-periphid = <0x10480180>; + max-frequency = <50000000>; + bus-width = <8>; + mmc-cap-mmc-highspeed; + vmmc-supply = <&ab8500_ldo_aux2_reg>; + + status = "okay"; + }; }; };