| Message ID | 1349959669-16366-3-git-send-email-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/11/2012 02:47 PM, Lokesh Vutla wrote: > Adding EMIF device tree data for OMAP5 boards. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > arch/arm/boot/dts/omap5.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index 5db33f4..445aeea 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -319,5 +319,29 @@ > ti,buffer-size = <128>; > ti,hwmods = "mcbsp3"; > }; > + > + emif1: emif@0x4c000000 { > + compatible = "ti,emif-4d5"; > + ti,hwmods = "emif1"; > + phy-type = <2>; > + reg = <0x4c000000 0x3ff>; Should 0x400. This parameter is the size, not the end address. > + interrupts = <0 110 0x4>; > + interrupt-parent = <&gic>; Please remove the interrupt-parent. It is not needed since DT will use the parent node to get it. It will avoid duplicating the entry for every nodes. > + hw-caps-read-idle-ctrl; > + hw-caps-ll-interface; > + hw-caps-temp-alert; > + }; > + > + emif2: emif@0x4d000000 { > + compatible = "ti,emif-4d5"; > + ti,hwmods = "emif2"; > + phy-type = <2>; Can you just add a comment to give more information. I know this is in the binding documentation, but some more comment never hurt. > + reg = <0x4d000000 0x3ff>; 0x400 as well. > + interrupts = <0 111 0x4>; > + interrupt-parent = <&gic>; Ditto. > + hw-caps-read-idle-ctrl; > + hw-caps-ll-interface; > + hw-caps-temp-alert; > + }; > }; > }; > Regards, Benoit
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 5db33f4..445aeea 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -319,5 +319,29 @@ ti,buffer-size = <128>; ti,hwmods = "mcbsp3"; }; + + emif1: emif@0x4c000000 { + compatible = "ti,emif-4d5"; + ti,hwmods = "emif1"; + phy-type = <2>; + reg = <0x4c000000 0x3ff>; + interrupts = <0 110 0x4>; + interrupt-parent = <&gic>; + hw-caps-read-idle-ctrl; + hw-caps-ll-interface; + hw-caps-temp-alert; + }; + + emif2: emif@0x4d000000 { + compatible = "ti,emif-4d5"; + ti,hwmods = "emif2"; + phy-type = <2>; + reg = <0x4d000000 0x3ff>; + interrupts = <0 111 0x4>; + interrupt-parent = <&gic>; + hw-caps-read-idle-ctrl; + hw-caps-ll-interface; + hw-caps-temp-alert; + }; }; };
Adding EMIF device tree data for OMAP5 boards. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- arch/arm/boot/dts/omap5.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)