| Message ID | 1350181976-18233-1-git-send-email-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Oct 14, 2012 at 04:32:55AM +0200, Marek Vasut wrote: > In the current code implementing the MXS SPI driver, every transferred > message had assigned status = 0, which is not correct. Properly assign > status returned from the I/O functions. Applied both, thanks.
Dear Mark Brown, > On Sun, Oct 14, 2012 at 04:32:55AM +0200, Marek Vasut wrote: > > In the current code implementing the MXS SPI driver, every transferred > > message had assigned status = 0, which is not correct. Properly assign > > status returned from the I/O functions. > > Applied both, thanks. Will they hit 3.7 please? Best regards, Marek Vasut
On Fri, Oct 26, 2012 at 02:31:53PM +0200, Marek Vasut wrote: > Dear Mark Brown, > > Applied both, thanks. > Will they hit 3.7 please? I hadn't been going to do that, no - nothing about them seemed especially urgent?
Dear Mark Brown, > On Fri, Oct 26, 2012 at 02:31:53PM +0200, Marek Vasut wrote: > > Dear Mark Brown, > > > > > Applied both, thanks. > > > > Will they hit 3.7 please? > > I hadn't been going to do that, no - nothing about them seemed > especially urgent? They're fixes, I'd be glad if you could slip them in. They're not urgent, but it'd be nice to have them included. Esp. since 3.7 seems like a really _good_ kernel for MXS, I'd love to have everything nicely polished in it. Best regards, Marek Vasut
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index edf1360..5a63bcd 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -480,7 +480,7 @@ static int mxs_spi_transfer_one(struct spi_master *master, first = last = 0; } - m->status = 0; + m->status = status; spi_finalize_current_message(master); return status;
In the current code implementing the MXS SPI driver, every transferred message had assigned status = 0, which is not correct. Properly assign status returned from the I/O functions. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Chris Ball <cjb@laptop.org> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: Shawn Guo <shawn.guo@linaro.org> --- drivers/spi/spi-mxs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)